--===============6867327946005237176== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 17, 2016, 12:08 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > looks good to me. > > > > but reminds me that I don't like string literals being hardcoded in different places. > > Harald Sitter wrote: > lol, I thought the same thing when I made the patch ^^ > > main() should get refactored to actually use the option objects of the Application at some point I'm not sure you can add strings in 16.12 - go ahead if you think so and to master - Kurt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129647/#review101479 ----------------------------------------------------------- On Dec. 13, 2016, 8:21 a.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129647/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 8:21 a.m.) > > > Review request for Konsole. > > > Repository: konsole > > > Description > ------- > > In previous incarnations of kuniqueapplication it used to inject a common > command option --nofork which is meant to bypass single-instance behavior. > Given that konsole can and is being invoked from scripts they may well want > to ensure that the fork they created is the actual instance of konsole. > i.e. to monitor return values and life time > > Presently, since the options are divergent between konsole4 and konsole5, > scripts are either incompatible with older konsoles or with newer konsoles. > To make life easier for everyone add an compat alias --nofork, which > behaves exactly like separate. > > (this unbreaks steam, which is a notable recent offender of falling into > this particular trap) > > > Diffs > ----- > > src/Application.cpp 5b352ec9b10899b44abbd6ee1609422ef1434620 > src/main.cpp 26d3da990b6aee564c0c9a237a56a65b1d372508 > > Diff: https://git.reviewboard.kde.org/r/129647/diff/ > > > Testing > ------- > > builds + noforks + separates > > poor steam also is happily opening a konsole now > > > Thanks, > > Harald Sitter > > --===============6867327946005237176== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129647/

On December 17th, 2016, 12:08 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:
looks good to me.
but reminds me that I don't like string literals being hardcoded in different places.
On December 17th, 2016, 12:12 p.m. UTC, Harald Sitter wrote:
lol, I thought the same thing when I made the patch ^^
main() should get refactored to actually use the option objects of the Application at some point

I'm not sure you can add strings in 16.12 - go ahead if you think so and to master

- Kurt

On December 13th, 2016, 8:21 a.m. UTC, Harald Sitter wrote:

Review request for Konsole.

By Harald Sitter.

Updated Dec. 13, 2016, 8:21 a.m.

Repository: konsole

Description

In previous incarnations of kuniqueapplication it used to inject a common
command option --nofork which is meant to bypass single-instance behavior.
Given that konsole can and is being invoked from scripts they may well want
to ensure that the fork they created is the actual instance of konsole.
i.e. to monitor return values and life time

Presently, since the options are divergent between konsole4 and konsole5,
scripts are either incompatible with older konsoles or with newer konsoles.
To make life easier for everyone add an compat alias --nofork, which
behaves exactly like separate.

(this unbreaks steam, which is a notable recent offender of falling into
 this particular trap)

Testing

builds + noforks + separates

poor steam also is happily opening a konsole now

Diffs

src/Application.cpp (5b352ec9b10899b44abbd6ee1609422ef1434620)
src/main.cpp (26d3da990b6aee564c0c9a237a56a65b1d372508)

--===============6867327946005237176==--