--===============0341939309027553125== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120323/#review101097 ----------------------------------------------------------- Ship it! I recall testing this patch earlier this year - go ahead and commit to master - we have about 4 months to test it - I don't have KDE on my Mac ATM since upgrading to Sierra - Kurt Hindenburg On Nov. 20, 2016, 5:12 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120323/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2016, 5:12 p.m.) > > > Review request for KDE Software on Mac OS X and Konsole. > > > Repository: konsole > > > Description > ------- > > OS X uses the Command (?, Apple) key as a modifier/opcode for keyboard accelerators aka shortcuts. This is the likely reason why Qt has swapped Qt::CTRL and Qt::META by default on that platform, but Konsole deactivates that feature. As a result, shortcuts are identical to what they are on other platforms, but not in line with what's standard on OS X. > > I introduced a proxy for the standard accelerator opcode, to minimise the amount of conditional code blocks required to adapt Konsole to OS X. There is an added benefit of not using the Control key for shortcuts: `Copy` can be the usual `Command-C` instead of `Ctrl-Shift-C` on other platforms; idem for the `Paste` shortcut. I've adapted the shortcuts of a few other actions to the key combinations OS X uses for those actions. > > > Diffs > ----- > > src/Application.cpp 5b352ec > src/ColorSchemeEditor.cpp f9bbe4f > src/CopyInputDialog.cpp 932744f > src/EditProfileDialog.cpp c2cca91 > src/HistorySizeDialog.cpp dbef529 > src/MainWindow.cpp 9b34788 > src/RenameTabDialog.cpp 6dc2b26 > src/Session.h 30248b3 > src/SessionController.cpp a527e99 > src/Shortcut_p.h PRE-CREATION > src/ViewManager.cpp c187e64 > src/tests/PartManualTest.cpp 19c1c94 > > Diff: https://git.reviewboard.kde.org/r/120323/diff/ > > > Testing > ------- > > on OS X 10.6.8 with kdelibs 4.14.1 (git/kde4). > > > Thanks, > > René J.V. Bertin > > --===============0341939309027553125== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120323/

Ship it! 

I recall testing this patch earlier this year - go ahead and commit to master - we have about 4 months to test it - I don't have KDE on my Mac ATM since upgrading to Sierra

- Kurt Hindenburg


On November 20th, 2016, 5:12 p.m. UTC, René J.V. Bertin wrote:

Review request for KDE Software on Mac OS X and Konsole.
By René J.V. Bertin.

Updated Nov. 20, 2016, 5:12 p.m.

Repository: konsole

Description 

OS X uses the Command (?, Apple) key as a modifier/opcode for keyboard accelerators aka shortcuts. This is the likely reason why Qt has swapped Qt::CTRL and Qt::META by default on that platform, but Konsole deactivates that feature. As a result, shortcuts are identical to what they are on other platforms, but not in line with what's standard on OS X.


I introduced a proxy for the standard accelerator opcode, to minimise the amount of conditional code blocks required to adapt Konsole to OS X. There is an added benefit of not using the Control key for shortcuts: Copy can be the usual Command-C instead of Ctrl-Shift-C on other platforms; idem for the Paste shortcut. I've adapted the shortcuts of a few other actions to the key combinations OS X uses for t
 hose actions.

Testing 

on OS X 10.6.8 with kdelibs 4.14.1 (git/kde4).

Diffs

  • src/Application.cpp (5b352ec)
  • src/ColorSchemeEditor.cpp (f9bbe4f)
  • src/CopyInputDialog.cpp (932744f)
  • src/EditProfileDialog.cpp (c2cca91)
  • src/HistorySizeDialog.cpp (dbef529)
  • src/MainWindow.cpp (9b34788)
  • src/RenameTabDialog.cpp (6dc2b26)
  • src/Session.h (30248b3)
  • src/SessionController.cpp (a527e99)
  • src/Shortcut_p.h (PRE-CREATION)
  • src/ViewManager.cpp (c187e64)
  • src/tests/PartManualTest.cpp (19c1c94)

View Diff
--===============0341939309027553125==--