[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: Review Request 120323: [OSX] shortcut adaptation to platform standards
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2016-11-20 17:12:09
Message-ID: 20161120171209.32069.46391 () mimi ! kde ! org
[Download RAW message or body]
--===============5857184237995463594==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120323/
-----------------------------------------------------------
(Updated Nov. 20, 2016, 6:12 p.m.)
Review request for KDE Software on Mac OS X and Konsole.
Changes
-------
It was more than time to update this RR...
Most of the patch now consists of replacing `Qt::CTRL` with the dedicated \
`Konsole::ACCEL` token, which allows `konsole` to be use the usual Command key in \
shortcuts while also using `Qt::DontSwapCtrlAndMeta` so shell control-sequences can \
work (they don't, but that's a different issue).
The patch also changes the defaults for the copy, paste, save-as and find actions, as \
well as for changing tabs.
Repository: konsole
Description
-------
OS X uses the Command (?, Apple) key as a modifier/opcode for keyboard accelerators \
aka shortcuts. This is the likely reason why Qt has swapped Qt::CTRL and Qt::META by \
default on that platform, but Konsole deactivates that feature. As a result, \
shortcuts are identical to what they are on other platforms, but not in line with \
what's standard on OS X.
I introduced a proxy for the standard accelerator opcode, to minimise the amount of \
conditional code blocks required to adapt Konsole to OS X. There is an added benefit \
of not using the Control key for shortcuts: `Copy` can be the usual `Command-C` \
instead of `Ctrl-Shift-C` on other platforms; idem for the `Paste` shortcut. I've \
adapted the shortcuts of a few other actions to the key combinations OS X uses for \
those actions.
Diffs (updated)
-----
src/Application.cpp 5b352ec
src/ColorSchemeEditor.cpp f9bbe4f
src/CopyInputDialog.cpp 932744f
src/EditProfileDialog.cpp c2cca91
src/HistorySizeDialog.cpp dbef529
src/MainWindow.cpp 9b34788
src/RenameTabDialog.cpp 6dc2b26
src/Session.h 30248b3
src/SessionController.cpp a527e99
src/Shortcut_p.h PRE-CREATION
src/ViewManager.cpp c187e64
src/tests/PartManualTest.cpp 19c1c94
Diff: https://git.reviewboard.kde.org/r/120323/diff/
Testing
-------
on OS X 10.6.8 with kdelibs 4.14.1 (git/kde4).
Thanks,
René J.V. Bertin
--===============5857184237995463594==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120323/">https://git.reviewboard.kde.org/r/120323/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and Konsole.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2016, 6:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It was more than time to update this RR...</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Most of the patch now consists of replacing <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Qt::CTRL</code> with the dedicated <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Konsole::ACCEL</code> token, which allows <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">konsole</code> to be use the usual Command key in shortcuts while also \
using <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">Qt::DontSwapCtrlAndMeta</code> so shell \
control-sequences can work (they don't, but that's a different issue).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The patch also changes the defaults for the copy, paste, save-as and find \
actions, as well as for changing tabs.</p></pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">OS X uses the Command (?, Apple) key as a \
modifier/opcode for keyboard accelerators aka shortcuts. This is the likely reason \
why Qt has swapped Qt::CTRL and Qt::META by default on that platform, but Konsole \
deactivates that feature. As a result, shortcuts are identical to what they are on \
other platforms, but not in line with what's standard on OS X.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
introduced a proxy for the standard accelerator opcode, to minimise the amount of \
conditional code blocks required to adapt Konsole to OS X. There is an added benefit \
of not using the Control key for shortcuts: <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Copy</code> can be the usual <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Command-C</code> instead of <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Ctrl-Shift-C</code> on other platforms; idem for the <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">Paste</code> shortcut. I've adapted the shortcuts of a few \
other actions to the key combinations OS X uses for t hose actions.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">on OS X 10.6.8 with kdelibs 4.14.1 \
(git/kde4).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/Application.cpp <span style="color: grey">(5b352ec)</span></li>
<li>src/ColorSchemeEditor.cpp <span style="color: grey">(f9bbe4f)</span></li>
<li>src/CopyInputDialog.cpp <span style="color: grey">(932744f)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(c2cca91)</span></li>
<li>src/HistorySizeDialog.cpp <span style="color: grey">(dbef529)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(9b34788)</span></li>
<li>src/RenameTabDialog.cpp <span style="color: grey">(6dc2b26)</span></li>
<li>src/Session.h <span style="color: grey">(30248b3)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(a527e99)</span></li>
<li>src/Shortcut_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(c187e64)</span></li>
<li>src/tests/PartManualTest.cpp <span style="color: grey">(19c1c94)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120323/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5857184237995463594==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic