[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: Review Request 129376: Let users configure the default search settings in konsole
From: Kurt Hindenburg <kurt.hindenburg () gmail ! com>
Date: 2016-11-19 15:20:37
Message-ID: 20161119152037.17025.44162 () mimi ! kde ! org
[Download RAW message or body]
--===============9145547402261757313==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Nov. 19, 2016, 3:15 p.m., Kurt Hindenburg wrote:
> > Thanks - it looks good enough to put in - we are close to the cut-off for new \
> > strings for 16.12
> > Typically you'd want any changes in the Settings and actual search widget to be \
> > saved
Actually we're about 10 day late for new strings - let me see what I can get in for \
16.12
- Kurt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129376/#review100944
-----------------------------------------------------------
On Nov. 11, 2016, 2 p.m., Ahmad Samir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129376/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2016, 2 p.m.)
>
>
> Review request for Konsole.
>
>
> Bugs: 332601
> http://bugs.kde.org/show_bug.cgi?id=332601
>
>
> Repository: konsole
>
>
> Description
> -------
>
> This patch should make it possible to configure the default search settings in \
> konsole. This can be done from the "Configure Konsole" dialogue from the General \
> tab using a new section titled "Default Search Settings". Users should be able to \
> configure:
> - Whether the search is case sensitive (off by default)
> - Whether regular expressions are used to search (off by default)
> - Whether to highlight all search matches (on by default)
> - The search direction whether to search from the bottom of the output to the top \
> or vice-versa (on by default).
> I kept the same default search settings as before.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt e7891f7
> src/IncrementalSearchBar.cpp 17a14ca
> src/settings/GeneralSettings.ui 8d19101
> src/settings/konsole.kcfg 075d2f7
>
> Diff: https://git.reviewboard.kde.org/r/129376/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ahmad Samir
>
>
--===============9145547402261757313==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129376/">https://git.reviewboard.kde.org/r/129376/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 19th, 2016, 3:15 p.m. UTC, <b>Kurt \
Hindenburg</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Thanks - it looks good enough to put in - we are close \
to the cut-off for new strings for 16.12</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Typically you'd want \
any changes in the Settings and actual search widget to be saved</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Actually we're about 10 day late for new strings - let me see what I can \
get in for 16.12</p></pre> <br />
<p>- Kurt</p>
<br />
<p>On November 11th, 2016, 2 p.m. UTC, Ahmad Samir wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konsole.</div>
<div>By Ahmad Samir.</div>
<p style="color: grey;"><i>Updated Nov. 11, 2016, 2 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=332601">332601</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch should make it possible to configure the \
default search settings in konsole. This can be done from the "Configure Konsole" \
dialogue from the General tab using a new section titled "Default Search Settings". \
Users should be able to configure:
- Whether the search is case sensitive (off by default)
- Whether regular expressions are used to search (off by default)
- Whether to highlight all search matches (on by default)
- The search direction whether to search from the bottom of the output to the top or \
vice-versa (on by default).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I kept the same default search settings \
as before.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(e7891f7)</span></li>
<li>src/IncrementalSearchBar.cpp <span style="color: grey">(17a14ca)</span></li>
<li>src/settings/GeneralSettings.ui <span style="color: grey">(8d19101)</span></li>
<li>src/settings/konsole.kcfg <span style="color: grey">(075d2f7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129376/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9145547402261757313==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic