'Re: Review Request 129345: Add setting for forcing use of multiple instances'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: Review Request 129345: Add setting for forcing use of multiple instances
From:       Kurt Hindenburg <kurt.hindenburg () gmail ! com>
Date:       2016-11-07 19:04:41
Message-ID: 20161107190441.6207.73425 () mimi ! kde ! org
[Download RAW message or body]

--===============4835077943811968559==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129345/#review100693
-----------------------------------------------------------


Ship it!




With the removal of kdelibs4, a number of these issues are a mess (--no-fork \
--separate).  I would say go ahead but perhaps make the default what it is now.

- Kurt Hindenburg


On Nov. 6, 2016, 1:10 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129345/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2016, 1:10 a.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Adds a setting for forcing the use of multiple instances instead of running all \
> instances in the same process. This way all terminals don't go down when one \
> instance crashes. 
> 
> Diffs
> -----
> 
> src/main.cpp c9c36c0 
> src/settings/GeneralSettings.ui ecfec94 
> src/settings/konsole.kcfg 932a38c 
> 
> Diff: https://git.reviewboard.kde.org/r/129345/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
> 


--===============4835077943811968559==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129345/">https://git.reviewboard.kde.org/r/129345/</a>
  </td>
    </tr>
   </table>
   <br />



<p>

Ship it!

</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With \
the removal of kdelibs4, a number of these issues are a mess (--no-fork --separate).  \
I would say go ahead but perhaps make the default what it is now.</p></pre>  <br />









<p>- Kurt Hindenburg</p>


<br />
<p>On November 6th, 2016, 1:10 a.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Konsole and Kurt Hindenburg.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>


<p style="color: grey;"><i>Updated Nov. 6, 2016, 1:10 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Adds a setting for forcing the use of multiple \
instances instead of running all instances in the same process. This way all \
terminals don't go down when one instance crashes.</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/main.cpp <span style="color: grey">(c9c36c0)</span></li>

 <li>src/settings/GeneralSettings.ui <span style="color: grey">(ecfec94)</span></li>

 <li>src/settings/konsole.kcfg <span style="color: grey">(932a38c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129345/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============4835077943811968559==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic