[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: Review Request 129281: [Konsole] Render text at primary font's baseline
From: Christoph Feck <cfeck () kde ! org>
Date: 2016-11-06 20:40:04
Message-ID: 20161106204004.6207.9261 () mimi ! kde ! org
[Download RAW message or body]
--===============2890363253342439313==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129281/
-----------------------------------------------------------
(Updated Nov. 6, 2016, 9:40 p.m.)
Review request for KDE Frameworks and Konsole.
Changes
-------
Use 'if' again (instead of ternary operator).
Bugs: 371687
http://bugs.kde.org/show_bug.cgi?id=371687
Repository: konsole
Description
-------
When Konsole draws a line of text, it first computes the rectangle of the line that \
the text covers (taking into account cells width and height), then passes this \
rectangle to the drawText(QRect, flags, text) call.
Qt detects if the selected font does not offer all characters in the text, and \
substitutes individual characters with a different font. Due to designer choices, the \
same font point size does not lead to same pixel height (or ascent size) in all \
fonts, so the substituted characters might be larger than the characters from the \
primary font.
Using a rectangle causes Qt to position glyphs relative to the bounding box of the \
text, instead of anchored to the baseline.
This patch uses a pixel position instead of a rectangle to draw the text, taking into \
account only the baseline of the primary font.
I have added all "frameworks" developers to increase possible test coverage.
Diffs (updated)
-----
src/TerminalDisplay.cpp 39a8b84
Diff: https://git.reviewboard.kde.org/r/129281/diff/
Testing
-------
On my system, lines with substituted Unicode characters are no longer shifted away \
from the baseline, and therefore do not appear cropped.
Further testing is needed, as there are many (equivalent, similar, or different) bug \
reports about font rendering on different systems, see \
https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=CONFIRMED&component=font&product=konsole
Thanks,
Christoph Feck
--===============2890363253342439313==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129281/">https://git.reviewboard.kde.org/r/129281/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Konsole.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2016, 9:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use 'if' again (instead of ternary operator).</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=371687">371687</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When Konsole draws a line of text, it first computes the rectangle of \
the line that the text covers (taking into account cells width and height), then \
passes this rectangle to the drawText(QRect, flags, text) call.
Qt detects if the selected font does not offer all characters in the text, and \
substitutes individual characters with a different font. Due to designer choices, the \
same font point size does not lead to same pixel height (or ascent size) in all \
fonts, so the substituted characters might be larger than the characters from the \
primary font.
Using a rectangle causes Qt to position glyphs relative to the bounding box of the \
text, instead of anchored to the baseline.
This patch uses a pixel position instead of a rectangle to draw the text, taking into \
account only the baseline of the primary font.
I have added all "frameworks" developers to increase possible test \
coverage.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">On my system, lines with substituted Unicode characters are no longer \
shifted away from the baseline, and therefore do not appear cropped.
Further testing is needed, as there are many (equivalent, similar, or different) bug \
reports about font rendering on different systems, see \
https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=CONFIRMED&component=font&product=konsole</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/TerminalDisplay.cpp <span style="color: grey">(39a8b84)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129281/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2890363253342439313==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic