[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: Review Request 129217: Fix re-parsing of command line arguments
From: Kurt Hindenburg <kurt.hindenburg () gmail ! com>
Date: 2016-10-22 19:31:42
Message-ID: 20161022193142.7781.9051 () mimi ! kde ! org
[Download RAW message or body]
--===============2506918587924191202==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129217/#review100209
-----------------------------------------------------------
Ship it!
Ship It!
- Kurt Hindenburg
On Oct. 18, 2016, 10:08 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129217/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2016, 10:08 p.m.)
>
>
> Review request for Konsole and Kurt Hindenburg.
>
>
> Repository: konsole
>
>
> Description
> -------
>
> If a new Konsole instance is launched via DBus (e. g. single process mode), it \
> re-used the QCommandLineParser each time, so each new instance would inherit all \
> parsed options.
> Most noticeably is if you have konsole running, press Shift+F4 in Dolphin to launch \
> a Konsole instance in the current folder (which leads Konsole to use a temporary \
> profile), and then try to open a new konsole instance outside of that, it would \
> open in the folder from Dolphin.
>
> Diffs
> -----
>
> src/Application.h 2c606b1
> src/Application.cpp e903981
> src/main.cpp 29f6f2b
>
> Diff: https://git.reviewboard.kde.org/r/129217/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
--===============2506918587924191202==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129217/">https://git.reviewboard.kde.org/r/129217/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Kurt Hindenburg</p>
<br />
<p>On October 18th, 2016, 10:08 p.m. UTC, Martin Tobias Holmedahl Sandsmark \
wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konsole and Kurt Hindenburg.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>
<p style="color: grey;"><i>Updated Oct. 18, 2016, 10:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If a new Konsole instance is launched via DBus (e. g. \
single process mode), it re-used the QCommandLineParser each time, so each new \
instance would inherit all parsed options.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Most noticeably is if \
you have konsole running, press Shift+F4 in Dolphin to launch a Konsole instance in \
the current folder (which leads Konsole to use a temporary profile), and then try to \
open a new konsole instance outside of that, it would open in the folder from \
Dolphin.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Application.h <span style="color: grey">(2c606b1)</span></li>
<li>src/Application.cpp <span style="color: grey">(e903981)</span></li>
<li>src/main.cpp <span style="color: grey">(29f6f2b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129217/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2506918587924191202==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic