[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: Review Request 128828: Make URL and file filtering individually configurable
From: Kurt Hindenburg <kurt.hindenburg () gmail ! com>
Date: 2016-10-15 13:25:29
Message-ID: 20161015132529.23881.123 () mimi ! kde ! org
[Download RAW message or body]
--===============2562692066548121111==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 4, 2016, 6:17 p.m., Kurt Hindenburg wrote:
> > What do you think about putting the Advanced->Show URL hints when... in the Mouse \
> > tab under the Underline options
> > I think some the Mouse options should be horizontal by oh well
>
> Martin Tobias Holmedahl Sandsmark wrote:
> Yeah, I was thinking about the same. I think maybe we should put all the hint-stuff \
> in a separate groupbox or something, on the same page.
> Kurt Hindenburg wrote:
> Are you still working on this? It looks like the next freeze will be in mid Nov.
>
> Martin Tobias Holmedahl Sandsmark wrote:
> Sorry, completely forgot this, can I do the re-doing of the settings UI in a \
> separate change? To keep this as small as possible.
Yes that's fine
- Kurt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128828/#review98881
-----------------------------------------------------------
On Sept. 4, 2016, 3:56 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128828/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2016, 3:56 p.m.)
>
>
> Review request for Konsole and Kurt Hindenburg.
>
>
> Bugs: 368234
> http://bugs.kde.org/show_bug.cgi?id=368234
>
>
> Repository: konsole
>
>
> Description
> -------
>
> Make it possible to select either just file filtering or URL filtering.
>
>
> Diffs
> -----
>
> src/EditProfileDialog.h bb2896f
> src/EditProfileDialog.cpp ec3216a
> src/EditProfileDialog.ui 8358bd3
> src/Profile.h 84a0acc
> src/Profile.cpp a8cec60
> src/SessionController.h 3ac06f5
> src/SessionController.cpp a1db8bc
> src/TerminalDisplay.h b3ffba7
> src/TerminalDisplay.cpp 3c4364c2d
> src/ViewManager.cpp ba3b72e
>
> Diff: https://git.reviewboard.kde.org/r/128828/diff/
>
>
> Testing
> -------
>
> Tested turning both on and off, testing that it is updated when editing config.
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
--===============2562692066548121111==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128828/">https://git.reviewboard.kde.org/r/128828/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 4th, 2016, 6:17 p.m. UTC, <b>Kurt \
Hindenburg</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">What do you think about putting the Advanced->Show \
URL hints when... in the Mouse tab under the Underline options</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think some the Mouse options should be horizontal by oh well</p></pre> </blockquote>
<p>On September 4th, 2016, 6:45 p.m. UTC, <b>Martin Tobias Holmedahl Sandsmark</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Yeah, I was thinking about the same. I think maybe we should put all the \
hint-stuff in a separate groupbox or something, on the same page.</p></pre> \
</blockquote>
<p>On October 7th, 2016, 10:42 p.m. UTC, <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Are \
you still working on this? It looks like the next freeze will be in mid \
Nov.</p></pre> </blockquote>
<p>On October 15th, 2016, 1:21 p.m. UTC, <b>Martin Tobias Holmedahl Sandsmark</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Sorry, completely forgot this, can I do the re-doing of the settings UI in \
a separate change? To keep this as small as possible.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes \
that's fine</p></pre> <br />
<p>- Kurt</p>
<br />
<p>On September 4th, 2016, 3:56 p.m. UTC, Martin Tobias Holmedahl Sandsmark \
wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konsole and Kurt Hindenburg.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2016, 3:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=368234">368234</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Make it possible to select either just file filtering \
or URL filtering.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested turning both on and off, testing that it is \
updated when editing config.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.h <span style="color: grey">(bb2896f)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(ec3216a)</span></li>
<li>src/EditProfileDialog.ui <span style="color: grey">(8358bd3)</span></li>
<li>src/Profile.h <span style="color: grey">(84a0acc)</span></li>
<li>src/Profile.cpp <span style="color: grey">(a8cec60)</span></li>
<li>src/SessionController.h <span style="color: grey">(3ac06f5)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(a1db8bc)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(b3ffba7)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(3c4364c2d)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(ba3b72e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128828/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2562692066548121111==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic