'Re: [Konsole-devel] Review Request 128416: Send EOF before sending SIGHUP when closing'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request 128416: Send EOF before sending SIGHUP when closing
From:       Martin Tobias Holmedahl Sandsmark <martin.sandsmark () kde ! org>
Date:       2016-07-10 11:09:19
Message-ID: 20160710110919.8816.49195 () mimi ! kde ! org
[Download RAW message or body]

--===============3905627965147978063==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On July 10, 2016, 8:11 a.m., Oswald Buddenhagen wrote:
> > src/Session.cpp, line 828
> > <https://git.reviewboard.kde.org/r/128416/diff/1/?file=471487#file471487line828>
> > 
> > // The PTY is not integrated with the process' waitFor*() functions.
> > _shellProcess->pty()->waitForBytesWritten();
> > 
> > i think that also obsoletes the surrounding comments, which make no sense to me.

Thanks, that works much better. I completely misunderstood the comment in \
KPtyProcess, I thought it was the waitForFinished() function that didn't work for \
some reason...

- Martin Tobias Holmedahl

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128416/#review97250
-----------------------------------------------------------

On July 9, 2016, 10:55 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128416/
> -----------------------------------------------------------
> 
> (Updated July 9, 2016, 10:55 p.m.)
> 
> 
> Review request for Konsole, Kurt Hindenburg and Oswald Buddenhagen.
> 
> 
> Bugs: 185140
> http://bugs.kde.org/show_bug.cgi?id=185140
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> According to http://permalink.gmane.org/gmane.comp.shells.bash.bugs/12602 (from \
> https://bugs.kde.org/show_bug.cgi?id=185140), sending EOF is the appropriate way of \
> telling e. g. bash to quit. 
> I wasn't able to get KPtyProcess to send that in a nice way (calling \
> setStandardInputFile(QProcess::nullDevice(), for example), so we fetch the EOF \
> character manually with tcgetattr and send that. 
> In addition KPtyProcess doesn't support waitForFinished(), so we have to spin the \
> event loop manually for KPtyProcess to notice that the child is finished. 
> 
> Diffs
> -----
> 
> src/Pty.h 0e7c478 
> src/Pty.cpp eaeda07 
> src/Session.cpp 768dc06 
> 
> Diff: https://git.reviewboard.kde.org/r/128416/diff/
> 
> 
> Testing
> -------
> 
> Running backgrounded processes (e. g. launching  Ťkate& ť) and then closing the \
> tab/window now leaves the backgrounded tasks running, which is apparently The Right \
> Thing. 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
> 

--===============3905627965147978063==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128416/">https://git.reviewboard.kde.org/r/128416/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On July 10th, 2016, 8:11 a.m. UTC, <b>Oswald \
Buddenhagen</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/128416/diff/1/?file=471487#file471487line828" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/Session.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">828</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">qApp</span><span class="o">-&gt;</span><span \
class="n">processEvents</span><span class="p">();</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">// \
The PTY is not integrated with the process' waitFor*() functions. \
_shellProcess-&gt;pty()-&gt;waitForBytesWritten();</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i \
think that also obsoletes the surrounding comments, which make no sense to \
me.</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks, that works much better. I completely misunderstood the comment in \
KPtyProcess, I thought it was the waitForFinished() function that didn't work for \
some reason...</p></pre> <br />

<p>- Martin Tobias Holmedahl</p>

<br />
<p>On July 9th, 2016, 10:55 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Konsole, Kurt Hindenburg and Oswald Buddenhagen.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>

<p style="color: grey;"><i>Updated July 9, 2016, 10:55 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=185140">185140</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">According to \
http://permalink.gmane.org/gmane.comp.shells.bash.bugs/12602 (from \
https://bugs.kde.org/show_bug.cgi?id=185140), sending EOF is the appropriate way of \
telling e. g. bash to quit.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I wasn't able to get KPtyProcess to \
send that in a nice way (calling setStandardInputFile(QProcess::nullDevice(), for \
example), so we fetch the EOF character manually with tcgetattr and send that.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">In addition KPtyProcess doesn't support waitForFinished(), so we have to \
spin the event loop manually for KPtyProcess to notice that the child is \
finished.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Running backgrounded processes (e. g. launching  \
Ťkate&amp; ť) and then closing the tab/window now leaves the backgrounded tasks \
running, which is apparently The Right Thing.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/Pty.h <span style="color: grey">(0e7c478)</span></li>

 <li>src/Pty.cpp <span style="color: grey">(eaeda07)</span></li>

 <li>src/Session.cpp <span style="color: grey">(768dc06)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128416/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3905627965147978063==--

[Attachment #3 (text/plain)]

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 