'Re: [Konsole-devel] Review Request 124908: Option to insert URLs as plain text'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request 124908: Option to insert URLs as plain text
From:       "Kurt Hindenburg" <kurt.hindenburg () gmail ! com>
Date:       2015-08-25 2:05:46
Message-ID: 20150825020546.4103.9700 () mimi ! kde ! org
[Download RAW message or body]

--===============3267211956396268120==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Aug. 24, 2015, 9:11 p.m., Peter Wu wrote:
> > Ship It!
> 
> Peter Wu wrote:
> Oh, I thought that the button "Ship It!" meant "publish it for review". Please bear \
> with me, I am new to this reviewboard :-)

Thanks for the patch - I'll give it a look over when I have time.

- Kurt

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124908/#review84303
-----------------------------------------------------------

On Aug. 24, 2015, 9:11 p.m., Peter Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124908/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 9:11 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Bugs: 304290
> http://bugs.kde.org/show_bug.cgi?id=304290
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> This patch allows the dnd menu to be disabled, making it possible to drag and
> drop URLs as text by default.
> 
> 
> Diffs
> -----
> 
> src/EditProfileDialog.h 5fed35d 
> src/EditProfileDialog.cpp 7ac6990 
> src/EditProfileDialog.ui dc5af01 
> src/Profile.h 8061b97 
> src/Profile.cpp 666cc4f 
> src/TerminalDisplay.h 6f3a7cd 
> src/TerminalDisplay.cpp 73b246a 
> src/ViewManager.cpp ed3ece2 
> 
> Diff: https://git.reviewboard.kde.org/r/124908/diff/
> 
> 
> Testing
> -------
> 
> Tested by applying the patch (based on v15.04.1-43-ga9bac17) on top of v15.08.0 + \
> v15.04.1-43-ga9bac17. 
> Verified that the option (when enabled) results in a dnd of plain text.
> 
> 
> Thanks,
> 
> Peter Wu
> 
> 

--===============3267211956396268120==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124908/">https://git.reviewboard.kde.org/r/124908/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On August 24th, 2015, 9:11 p.m. UTC, <b>Peter \
Wu</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre>  </blockquote>

 <p>On August 24th, 2015, 9:12 p.m. UTC, <b>Peter Wu</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oh, I \
thought that the button "Ship It!" meant "publish it for review". Please bear with \
me, I am new to this reviewboard :-)</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks for the patch - I'll give it a look over when I have time.</p></pre> \
<br />

<p>- Kurt</p>

<br />
<p>On August 24th, 2015, 9:11 p.m. UTC, Peter Wu wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Konsole.</div>
<div>By Peter Wu.</div>

<p style="color: grey;"><i>Updated Aug. 24, 2015, 9:11 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=304290">304290</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch allows the dnd menu to be disabled, making it possible to \
drag and drop URLs as text by default.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested by applying the patch (based on v15.04.1-43-ga9bac17) on top of \
v15.08.0 + v15.04.1-43-ga9bac17.

Verified that the option (when enabled) results in a dnd of plain text.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/EditProfileDialog.h <span style="color: grey">(5fed35d)</span></li>

 <li>src/EditProfileDialog.cpp <span style="color: grey">(7ac6990)</span></li>

 <li>src/EditProfileDialog.ui <span style="color: grey">(dc5af01)</span></li>

 <li>src/Profile.h <span style="color: grey">(8061b97)</span></li>

 <li>src/Profile.cpp <span style="color: grey">(666cc4f)</span></li>

 <li>src/TerminalDisplay.h <span style="color: grey">(6f3a7cd)</span></li>

 <li>src/TerminalDisplay.cpp <span style="color: grey">(73b246a)</span></li>

 <li>src/ViewManager.cpp <span style="color: grey">(ed3ece2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124908/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3267211956396268120==--

[Attachment #3 (text/plain)]

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 