From konsole-devel Sun Aug 16 20:20:37 2015 From: "Kurt Hindenburg" Date: Sun, 16 Aug 2015 20:20:37 +0000 To: konsole-devel Subject: Re: [Konsole-devel] Review Request 109571: Add option to close tab on middle (wheel) mouse button cl Message-Id: <20150816202037.3671.81111 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=konsole-devel&m=143975644815909 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0469608232795650451==" --===============0469608232795650451== Content-Type: multipart/alternative; boundary="===============7115980043525406750==" --===============7115980043525406750== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109571/#review83899 ----------------------------------------------------------- mouseMiddleClick() was from KDE4 KTabbar. Qt5 QTabBar doesn't have the signal mouseMiddleClick() - something like https://mail.kde.org/pipermail/kde-frameworks-devel/2014-November/020301.html might be doable. If anyone wants to update the patch for Qt5, I'll give it another look. - Kurt Hindenburg On March 18, 2013, 9:34 p.m., Oleksandr Sochka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/109571/ > ----------------------------------------------------------- > > (Updated March 18, 2013, 9:34 p.m.) > > > Review request for Konsole. > > > Repository: konsole > > > Description > ------- > > There is no action assigned on middle mouse button right now > and this patch adds an option to Settings->Configure->Taskbar which enables > closing a tab like in browsers/different editors using wheel click. > > Option is disabled by default. > > > Diffs > ----- > > src/MainWindow.h b297883 > src/MainWindow.cpp 0ba82f0 > src/ViewContainer.h d5bdf73 > src/ViewContainer.cpp 63c187d > src/ViewManager.h f039a27 > src/ViewManager.cpp 8a902d0 > src/settings/TabBarSettings.ui b9ace21 > src/settings/konsole.kcfg b850d9a > > Diff: https://git.reviewboard.kde.org/r/109571/diff/ > > > Testing > ------- > > Tested manually > > > Thanks, > > Oleksandr Sochka > > --===============7115980043525406750== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109571/ 

mouseMiddleClick() was from KDE4 KTabbar.  Qt5 QTabBar doesn't have the signal mouseMiddleClick() - something like https://mail.kde.org/pipermail/kde-frameworks-devel/2014-November/020301.html might be doable.  If anyone wants to update the patch for Qt5, I'll give it another look.

- Kurt Hindenburg


On March 18th, 2013, 9:34 p.m. UTC, Oleksandr Sochka wrote:

Review request for Konsole.
By Oleksandr Sochka.

Updated March 18, 2013, 9:34 p.m.

Repository: konsole

Description 

There is no action assigned on middle mouse button right now
and this patch adds an option to Settings->Configure->Taskbar which enables 
closing a tab like in browsers/different editors using wheel click.

Option is disabled by default.

Testing 

Tested manually

Diffs

  • src/MainWindow.h (b297883)
  • src/MainWindow.cpp (0ba82f0)
  • src/ViewContainer.h (d5bdf73)
  • src/ViewContainer.cpp (63c187d)
  • src/ViewManager.h (f039a27)
  • src/ViewManager.cpp (8a902d0)
  • src/settings/TabBarSettings.ui (b9ace21)
  • src/settings/konsole.kcfg (b850d9a)

View Diff
--===============7115980043525406750==-- --===============0469608232795650451== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka29uc29sZS1k ZXZlbCBtYWlsaW5nIGxpc3QKa29uc29sZS1kZXZlbEBrZGUub3JnCmh0dHBzOi8vbWFpbC5rZGUu b3JnL21haWxtYW4vbGlzdGluZm8va29uc29sZS1kZXZlbAo= --===============0469608232795650451==--