[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request 123804: Store History in cache instead of tmp
From: "Martin Tobias Holmedahl Sandsmark" <martin.sandsmark () kde ! org>
Date: 2015-07-17 20:18:36
Message-ID: 20150717201836.27368.92946 () mimi ! kde ! org
[Download RAW message or body]
--===============1172191168158272343==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On July 15, 2015, 2:33 a.m., Kurt Hindenburg wrote:
> > I don't think this a good idea to have this as the default. It will now fill up \
> > the user's home space.
> > Also I would prefer you not commit things like this w/o comments.
>
> Rex Dieter wrote:
> You think filling /tmp is safer? At least 2 distros needed this (fedora and debian \
> so far), do you have any better suggestions to handle this?
> sorry for the rush, I guess I should have pinged at least once more before moving \
> forward.
> Kurt Hindenburg wrote:
> CAn you link why those distro use a small /tmp? It has been a while since I last \
> looked at this but I thought we'd rather have /tmp fill up rather than users's home \
> location ("~/.cache/<APPNAME>"). A new release is coming out soon - we'll have to \
> decide on something or give the users to pick where they want to store it.
> Rex Dieter wrote:
> Distros are starting to use smaller (VM-backed) tmpfs for /tmp (as indicated in my \
> initial post here). so, storing potentially unlimited-size items there is bad. \
> /var/tmp would be better (than /tmp), but I couldn't find any api/standard for \
> using that.
> If it helps, if using cache as proposed here, users *do* technically have a choice, \
> they can define a custom XDG_CACHE_DIR environment variable (they could with TMPDIR \
> too, but that has larger downsides and consequences, ie, makes /tmp essentially not \
> used for anything).
> Rex Dieter wrote:
> Background on tmpfs feature for fedora, \
> https://fedoraproject.org/wiki/Features/tmp-on-tmpfs
I'm pretty sure most applications handles /tmp being full better than the partition \
the home folder is on, tbh. I'd rather have something hang because it can't create a \
socket than data loss because some application can't save its data.
- Martin Tobias Holmedahl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123804/#review82516
-----------------------------------------------------------
On July 14, 2015, 7:43 p.m., Rex Dieter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123804/
> -----------------------------------------------------------
>
> (Updated July 14, 2015, 7:43 p.m.)
>
>
> Review request for Konsole.
>
>
> Bugs: 173283
> http://bugs.kde.org/show_bug.cgi?id=173283
>
>
> Repository: konsole
>
>
> Description
> -------
>
> Some distros have small /tmp and/or use tmpfs, and large history
> (esp unlimited scrollback) can potentially fill disk or VM.
>
>
> Diffs
> -----
>
> src/History.cpp da7fb7b
>
> Diff: https://git.reviewboard.kde.org/r/123804/diff/
>
>
> Testing
> -------
>
> Confirmed history no longer uses /tmp
>
>
> Thanks,
>
> Rex Dieter
>
>
--===============1172191168158272343==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123804/">https://git.reviewboard.kde.org/r/123804/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 15th, 2015, 2:33 a.m. UTC, <b>Kurt \
Hindenburg</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I don't think this a good idea to have this as the \
default. It will now fill up the user's home space.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also \
I would prefer you not commit things like this w/o comments.</p></pre> </blockquote>
<p>On July 15th, 2015, 3:21 p.m. UTC, <b>Rex Dieter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
think filling /tmp is safer? At least 2 distros needed this (fedora and debian so \
far), do you have any better suggestions to handle this?</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">sorry \
for the rush, I guess I should have pinged at least once more before moving \
forward.</p></pre> </blockquote>
<p>On July 16th, 2015, 1:55 a.m. UTC, <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">CAn \
you link why those distro use a small /tmp? It has been a while since I last looked \
at this but I thought we'd rather have /tmp fill up rather than users's home location \
("~/.cache/<APPNAME>"). A new release is coming out soon - we'll have to decide \
on something or give the users to pick where they want to store it.</p></pre> \
</blockquote>
<p>On July 17th, 2015, 12:43 p.m. UTC, <b>Rex Dieter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Distros are starting to use smaller (VM-backed) tmpfs for /tmp (as \
indicated in my initial post here). so, storing potentially unlimited-size items \
there is bad. /var/tmp would be better (than /tmp), but I couldn't find any \
api/standard for using that. </p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">If it helps, if using \
cache as proposed here, users <em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">do</em> technically have a choice, they \
can define a custom XDG_CACHE_DIR environment variable (they could with TMPDIR too, \
but that has larger downsides and consequences, ie, makes /tmp essentially not used \
for anything).</p></pre> </blockquote>
<p>On July 17th, 2015, 12:44 p.m. UTC, <b>Rex Dieter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Background on tmpfs feature for fedora, \
https://fedoraproject.org/wiki/Features/tmp-on-tmpfs</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
pretty sure most applications handles /tmp being full better than the partition the \
home folder is on, tbh. I'd rather have something hang because it can't create a \
socket than data loss because some application can't save its data.</p></pre> <br />
<p>- Martin Tobias Holmedahl</p>
<br />
<p>On July 14th, 2015, 7:43 p.m. UTC, Rex Dieter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konsole.</div>
<div>By Rex Dieter.</div>
<p style="color: grey;"><i>Updated July 14, 2015, 7:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=173283">173283</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Some distros have small /tmp and/or use tmpfs, and \
large history (esp unlimited scrollback) can potentially fill disk or VM.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Confirmed history no longer uses /tmp</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/History.cpp <span style="color: grey">(da7fb7b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123804/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1172191168158272343==--
[Attachment #3 (text/plain)]
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic