'Re: [Konsole-devel] Review Request 124142: Fix storing of changed default profile'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request 124142: Fix storing of changed default profile
From:       "Martin Tobias Holmedahl Sandsmark" <martin.sandsmark () kde ! org>
Date:       2015-07-04 4:12:19
Message-ID: 20150704041219.1689.83062 () mimi ! kde ! org
[Download RAW message or body]

--===============1600254205254919571==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124142/
-----------------------------------------------------------

(Updated July 4, 2015, 4:12 a.m.)

Status
------

This change has been marked as submitted.

Review request for Konsole and Kurt Hindenburg.

Changes
-------

Submitted with commit 4ec5d3092d6cbda5ccfb838e2ef71f6d650b5ac4 by Martin T. H. \
Sandsmark to branch master.

Bugs: 303356
    http://bugs.kde.org/show_bug.cgi?id=303356

Repository: konsole

Description
-------

If for some reason no profile is loaded, i. e. only the built-in
fallback default values are used, we need to create a new profile to
ensure that changes to the profile are actually persisted.

This has worked more or less by chance for most people so far, because
the default is to load the Shell.profile that is shipped with Konsole.
But if for example the konsolerc config file has an empty value for
DefaultProfile it will load the builtin fallback profile, which can't be
saved.

Diffs
-----

  src/Profile.cpp 13c51c8 
  src/ProfileManager.cpp 0a3c125 

Diff: https://git.reviewboard.kde.org/r/124142/diff/

Testing
-------

Deleted all profiles, set empty DefaultProfile in konsolerc, change some settings in \
the profile, close konsole, and restart konsole and see that my changes persist.

Thanks,

Martin Tobias Holmedahl Sandsmark

--===============1600254205254919571==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124142/">https://git.reviewboard.kde.org/r/124142/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Konsole and Kurt Hindenburg.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>

<p style="color: grey;"><i>Updated July 4, 2015, 4:12 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 4ec5d3092d6cbda5ccfb838e2ef71f6d650b5ac4 by Martin \
T. H. Sandsmark to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=303356">303356</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If for some reason no profile is loaded, i. e. only \
the built-in fallback default values are used, we need to create a new profile to
ensure that changes to the profile are actually persisted.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This has worked more or less by chance for most people \
so far, because the default is to load the Shell.profile that is shipped with \
Konsole. But if for example the konsolerc config file has an empty value for
DefaultProfile it will load the builtin fallback profile, which can't be
saved.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Deleted all profiles, set empty DefaultProfile in \
konsolerc, change some settings in the profile, close konsole, and restart konsole \
and see that my changes persist.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/Profile.cpp <span style="color: grey">(13c51c8)</span></li>

 <li>src/ProfileManager.cpp <span style="color: grey">(0a3c125)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124142/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1600254205254919571==--

[Attachment #3 (text/plain)]

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 