'Re: [Konsole-devel] Review Request 120693: fix 337241 - Konsole hides tabs when moving them using ke'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request 120693: fix 337241 - Konsole hides tabs when moving them using ke
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2014-10-22 1:56:41
Message-ID: 20141022015641.18178.15667 () probe ! kde ! org
[Download RAW message or body]

--===============3178851716695569400==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120693/#review68869
-----------------------------------------------------------

src/ViewContainer.cpp
<https://git.reviewboard.kde.org/r/120693/#comment48158>

    Does this comment still apply, does it need to be moved or removed? There are now two blank \
lines after this comment, at least RB makes me believe there are.

- Christoph Feck

On Oct. 21, 2014, 5:47 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120693/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 5:47 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Bugs: 337241
> http://bugs.kde.org/show_bug.cgi?id=337241
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> We dont need to explicitly remove the tab from the tabbar while the view is being moved, it \
> will be automatically removed when the widget is removed from the stacked widget 
> 
> Diffs
> -----
> 
> src/ViewContainer.cpp d425e0e 
> 
> Diff: https://git.reviewboard.kde.org/r/120693/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
> 

--===============3178851716695569400==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120693/">https://git.reviewboard.kde.org/r/120693/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; \
padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/120693/diff/1/?file=321458#file321458line578" \
style="color: black; font-weight: bold; text-decoration: underline;">src/ViewContainer.cpp</a>  \
<span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
TabbedViewContainer::moveViewWidget(int fromIndex , int toIndex)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">578</font></th>  <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; ">    <span class="c1">// FIXME - This will lose properties of \
the tab other than</span></pre></td>  <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">578</font></th>  <td \
bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    \
<span class="c1">// FIXME - This will lose properties of the tab other than</span></pre></td>  \
</tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Does this comment still apply, \
does it need to be moved or removed? There are now two blank lines after this comment, at least \
RB makes me believe there are.</p></pre>  </div>
</div>
<br />

<p>- Christoph Feck</p>

<br />
<p>On October 21st, 2014, 5:47 p.m. UTC, Arjun AK wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Konsole.</div>
<div>By Arjun AK.</div>

<p style="color: grey;"><i>Updated Oct. 21, 2014, 5:47 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=337241">337241</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We dont need to \
explicitly remove the tab from the tabbar while the view is being moved, it will be \
automatically removed when the widget is removed from the stacked widget</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/ViewContainer.cpp <span style="color: grey">(d425e0e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120693/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3178851716695569400==--

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 