'Re: [Konsole-devel] Review Request 119909: Version the konsoleprivate library'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request 119909: Version the konsoleprivate library
From:       "Sune Vuorela" <kde () pusling ! com>
Date:       2014-09-13 19:13:06
Message-ID: 20140913191306.8755.58327 () probe ! kde ! org
[Download RAW message or body]

--===============6014045657854633330==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119909/#review66428
-----------------------------------------------------------

Looks better now

- Sune Vuorela

On Sept. 13, 2014, 4:52 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119909/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2014, 4:52 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> This allows (on packaging level at least) co-existence of kdelibs4 & KF5 \
> konsole-part 
> 
> Diffs
> -----
> 
> CMakeLists.txt 3655540 
> src/CMakeLists.txt 551a148 
> src/main.cpp 955e028 
> src/config-konsole.h.cmake 2860d68 
> 
> Diff: https://git.reviewboard.kde.org/r/119909/diff/
> 
> 
> Testing
> -------
> 
> Builds
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
> 

--===============6014045657854633330==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119909/">https://git.reviewboard.kde.org/r/119909/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
better now</p></pre>  <br />

<p>- Sune Vuorela</p>

<br />
<p>On September 13th, 2014, 4:52 p.m. UTC, Hrvoje Senjan wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Konsole and Kurt Hindenburg.</div>
<div>By Hrvoje Senjan.</div>

<p style="color: grey;"><i>Updated Sept. 13, 2014, 4:52 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This allows (on packaging level at least) co-existence \
of kdelibs4 &amp; KF5 konsole-part</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(3655540)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(551a148)</span></li>

 <li>src/main.cpp <span style="color: grey">(955e028)</span></li>

 <li>src/config-konsole.h.cmake <span style="color: grey">(2860d68)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119909/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6014045657854633330==--

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 