'Re: [Konsole-devel] Review Request 119004: Fix crash caused by dereferencing a deleted submenu'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request 119004: Fix crash caused by dereferencing a deleted submenu
From:       "Commit Hook" <null () kde ! org>
Date:       2014-07-02 14:28:13
Message-ID: 20140702142813.22336.54820 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119004/#review61492
-----------------------------------------------------------

This review has been submitted with commit 86ee13f5839e24adf3fa1d11320f2ac93d8a3651 \
by Kurt Hindenburg to branch frameworks.

- Commit Hook

On June 28, 2014, 7:43 p.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119004/
> -----------------------------------------------------------
> 
> (Updated June 28, 2014, 7:43 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Submenu of new "newTabMenuAction" is dereferenced in multiple places without first \
> checking whether it is null or not which can lead to a crash, especially since we \
> delete it (https://projects.kde.org/projects/kde/applications/konsole/repository/revisions/c4f7f512f3bbd8235947defc8f3f848244d7ca1b/entry/src/MainWindow.cpp#L422) \
> if there is only one profile to be shown. 
> 
> Diffs
> -----
> 
> src/MainWindow.cpp 86d04de 
> 
> Diff: https://git.reviewboard.kde.org/r/119004/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119004/">https://git.reviewboard.kde.org/r/119004/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 86ee13f5839e24adf3fa1d11320f2ac93d8a3651 by Kurt Hindenburg to \
branch frameworks.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On June 28th, 2014, 7:43 p.m. UTC, Arjun Ak wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Konsole.</div>
<div>By Arjun Ak.</div>

<p style="color: grey;"><i>Updated June 28, 2014, 7:43 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submenu of new &quot;newTabMenuAction&quot; is dereferenced in multiple \
places without first checking whether it is null or not which can lead to a crash, \
especially since we delete it \
(https://projects.kde.org/projects/kde/applications/konsole/repository/revisions/c4f7f512f3bbd8235947defc8f3f848244d7ca1b/entry/src/MainWindow.cpp#L422) \
if there is only one profile to be shown.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/MainWindow.cpp <span style="color: grey">(86d04de)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119004/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 