--===============0612798631838086055== Content-Type: multipart/alternative; boundary="===============6057658215031477881==" --===============6057658215031477881== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Feb. 13, 2014, 3:32 p.m., Kurt Hindenburg wrote: > > Thanks for the patch; however, I don't think this is worth adding. The user can right-click->close tab. Please refer to Bug 191751 https://bugs.kde.org/show_bug.cgi?id=191751 for the full discussion that lead to this patch, the option is disabled by default and it is there for the users who want to have this feature - Helmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109571/#review49713 ----------------------------------------------------------- On March 18, 2013, 9:34 p.m., Oleksandr Sochka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/109571/ > ----------------------------------------------------------- > > (Updated March 18, 2013, 9:34 p.m.) > > > Review request for Konsole. > > > Repository: konsole > > > Description > ------- > > There is no action assigned on middle mouse button right now > and this patch adds an option to Settings->Configure->Taskbar which enables > closing a tab like in browsers/different editors using wheel click. > > Option is disabled by default. > > > Diffs > ----- > > src/MainWindow.h b297883 > src/MainWindow.cpp 0ba82f0 > src/ViewContainer.h d5bdf73 > src/ViewContainer.cpp 63c187d > src/ViewManager.h f039a27 > src/ViewManager.cpp 8a902d0 > src/settings/TabBarSettings.ui b9ace21 > src/settings/konsole.kcfg b850d9a > > Diff: https://git.reviewboard.kde.org/r/109571/diff/ > > > Testing > ------- > > Tested manually > > > Thanks, > > Oleksandr Sochka > > --===============6057658215031477881== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109571/

On February 13th, 2014, 3:32 p.m. UTC, Kurt Hindenburg wrote:

Thanks for the patch; however, I don't think this is worth adding.  The user can right-click->close tab.
Please refer to Bug 191751 https://bugs.kde.org/show_bug.cgi?id=191751  for the full discussion that lead to this patch, the option is disabled by default and it is there for the users who want to have this feature

- Helmy


On March 18th, 2013, 9:34 p.m. UTC, Oleksandr Sochka wrote:

Review request for Konsole.
By Oleksandr Sochka.

Updated March 18, 2013, 9:34 p.m.

Repository: konsole

Description 

There is no action assigned on middle mouse button right now
and this patch adds an option to Settings->Configure->Taskbar which enables 
closing a tab like in browsers/different editors using wheel click.

Option is disabled by default.

Testing 

Tested manually

Diffs

  • src/MainWindow.h (b297883)
  • src/MainWindow.cpp (0ba82f0)
  • src/ViewContainer.h (d5bdf73)
  • src/ViewContainer.cpp (63c187d)
  • src/ViewManager.h (f039a27)
  • src/ViewManager.cpp (8a902d0)
  • src/settings/TabBarSettings.ui (b9ace21)
  • src/settings/konsole.kcfg (b850d9a)

View Diff
--===============6057658215031477881==-- --===============0612798631838086055== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ konsole-devel mailing list konsole-devel@kde.org https://mail.kde.org/mailman/listinfo/konsole-devel --===============0612798631838086055==--