[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request 109571: Add option to close tab on middle (wheel) mouse button cl
From: "Kurt Hindenburg" <kurt.hindenburg () gmail ! com>
Date: 2014-02-13 15:32:10
Message-ID: 20140213153210.20140.16125 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109571/#review49713
-----------------------------------------------------------
Thanks for the patch; however, I don't think this is worth adding. The user can right-click->close tab.
- Kurt Hindenburg
On March 18, 2013, 9:34 p.m., Oleksandr Sochka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/109571/
> -----------------------------------------------------------
>
> (Updated March 18, 2013, 9:34 p.m.)
>
>
> Review request for Konsole.
>
>
> Repository: konsole
>
>
> Description
> -------
>
> There is no action assigned on middle mouse button right now
> and this patch adds an option to Settings->Configure->Taskbar which enables
> closing a tab like in browsers/different editors using wheel click.
>
> Option is disabled by default.
>
>
> Diffs
> -----
>
> src/MainWindow.h b297883
> src/MainWindow.cpp 0ba82f0
> src/ViewContainer.h d5bdf73
> src/ViewContainer.cpp 63c187d
> src/ViewManager.h f039a27
> src/ViewManager.cpp 8a902d0
> src/settings/TabBarSettings.ui b9ace21
> src/settings/konsole.kcfg b850d9a
>
> Diff: https://git.reviewboard.kde.org/r/109571/diff/
>
>
> Testing
> -------
>
> Tested manually
>
>
> Thanks,
>
> Oleksandr Sochka
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/109571/">https://git.reviewboard.kde.org/r/109571/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch; \
however, I don't think this is worth adding. The user can right-click->close \
tab.</pre> <br />
<p>- Kurt Hindenburg</p>
<br />
<p>On March 18th, 2013, 9:34 p.m. UTC, Oleksandr Sochka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Konsole.</div>
<div>By Oleksandr Sochka.</div>
<p style="color: grey;"><i>Updated March 18, 2013, 9:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There is no action assigned on middle mouse button right now and this \
patch adds an option to Settings->Configure->Taskbar which enables closing a \
tab like in browsers/different editors using wheel click.
Option is disabled by default.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested manually</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MainWindow.h <span style="color: grey">(b297883)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(0ba82f0)</span></li>
<li>src/ViewContainer.h <span style="color: grey">(d5bdf73)</span></li>
<li>src/ViewContainer.cpp <span style="color: grey">(63c187d)</span></li>
<li>src/ViewManager.h <span style="color: grey">(f039a27)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(8a902d0)</span></li>
<li>src/settings/TabBarSettings.ui <span style="color: grey">(b9ace21)</span></li>
<li>src/settings/konsole.kcfg <span style="color: grey">(b850d9a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/109571/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic