[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request 115400: Add support for Unity quicklists to Konsole
From: "Commit Hook" <null () kde ! org>
Date: 2014-02-04 15:18:22
Message-ID: 20140204151822.4923.21966 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115400/#review48927
-----------------------------------------------------------
This review has been submitted with commit 4ef99992da2a409967160048696283541a8e7dfe \
by Kurt Hindenburg to branch master.
- Commit Hook
On Jan. 30, 2014, 2:11 p.m., Ivo Anjo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115400/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 2:11 p.m.)
>
>
> Review request for Konsole.
>
>
> Bugs: 330580
> http://bugs.kde.org/show_bug.cgi?id=330580
>
>
> Repository: konsole
>
>
> Description
> -------
>
> This patch adds support for the quicklists feature of Unity, as per the \
> freedesktop.org "Desktop Entry Specification".
>
> With this patch, a new action is added "Open a New Window" which is very useful \
> when konsole is used in Unity, as it allows you to create a new window without \
> having to use menus or keyboard shortcuts.
>
> Gnome-terminal also includes similar support, and also Firefox. I basically copied \
> the Firefox desktop entry, as it already had translations of this action for a \
> bunch of languages.
> My main motivation for this is that I've always had the habit of using the \
> best-of-breed applications on my desktop, regardless of the environment. So when \
> I'm using KDE or Unity or XFCE I always use firefox, gajim, konsole, kate, gnote, \
> ... This is a small extra for Unity users, and has no drawbacks for other users, so \
> I'd love to see this upstream.
>
> Diffs
> -----
>
> desktop/konsole.desktop 01f130b
>
> Diff: https://git.reviewboard.kde.org/r/115400/diff/
>
>
> Testing
> -------
>
> Replaced .desktop on my ubuntu installation and confirmed that I had the quicklist \
> now.
> Picture: http://i.imgur.com/FQXt1uH.png
>
>
> Thanks,
>
> Ivo Anjo
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115400/">https://git.reviewboard.kde.org/r/115400/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 4ef99992da2a409967160048696283541a8e7dfe by Kurt Hindenburg to \
branch master.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On January 30th, 2014, 2:11 p.m. UTC, Ivo Anjo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Konsole.</div>
<div>By Ivo Anjo.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2014, 2:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=330580">330580</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for the quicklists feature of Unity, as per the \
freedesktop.org "Desktop Entry Specification".
With this patch, a new action is added "Open a New Window" which is very \
useful when konsole is used in Unity, as it allows you to create a new window without \
having to use menus or keyboard shortcuts.
Gnome-terminal also includes similar support, and also Firefox. I basically copied \
the Firefox desktop entry, as it already had translations of this action for a bunch \
of languages.
My main motivation for this is that I've always had the habit of using the \
best-of-breed applications on my desktop, regardless of the environment. So when \
I'm using KDE or Unity or XFCE I always use firefox, gajim, konsole, kate, gnote, \
... This is a small extra for Unity users, and has no drawbacks for other users, so \
I'd love to see this upstream.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Replaced .desktop on my ubuntu installation and confirmed that I had the \
quicklist now.
Picture: http://i.imgur.com/FQXt1uH.png</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktop/konsole.desktop <span style="color: grey">(01f130b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115400/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic