[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request 114376: Implement a file filter in Konsole that uses POSIX portab
From: "Martin Tobias Holmedahl Sandsmark" <martin.sandsmark () kde ! org>
Date: 2013-12-13 10:46:06
Message-ID: 20131213104606.1783.11907 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114376/#review45633
-----------------------------------------------------------
Just one minor nitpick, otherwise it looks okay to me. But should probably get a \
final ship it from hindenburg.
src/Filter.h
<http://git.reviewboard.kde.org/r/114376/#comment32592>
Is this still needed?
- Martin Tobias Holmedahl Sandsmark
On Dec. 10, 2013, 2:13 a.m., Adam Treat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114376/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2013, 2:13 a.m.)
>
>
> Review request for Konsole and Kurt Hindenburg.
>
>
> Repository: konsole
>
>
> Description
> -------
>
> Implement a new file filter using POSIX Portable Filename Character Set
> along with KDE's mimetype database of file extension blobs that filters
> text matching a POSIX portable pathname and underlines it very much like
> links.
>
> Info on the character set allowed can be found at this link:
> http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_267
>
>
> Diffs
> -----
>
> src/EditProfileDialog.ui 82298cf
> src/Filter.h cbcc8e2
> src/Filter.cpp 5818054
> src/SessionController.h 2ff7910
> src/SessionController.cpp 62c1d0b
>
> Diff: http://git.reviewboard.kde.org/r/114376/diff/
>
>
> Testing
> -------
>
> Tested on my local system with a chromium code base and displaying all the local \
> files therein and displaying in konsole and opening via filter in kate.
>
> Thanks,
>
> Adam Treat
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114376/">http://git.reviewboard.kde.org/r/114376/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just one minor nitpick, \
otherwise it looks okay to me. But should probably get a final ship it from \
hindenburg.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/114376/diff/1/?file=223622#file223622line24" \
style="color: black; font-weight: bold; text-decoration: underline;">src/Filter.h</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">24</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include <QtCore/QFileInfo></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this \
still needed?</pre> </div>
<br />
<p>- Martin Tobias Holmedahl Sandsmark</p>
<br />
<p>On December 10th, 2013, 2:13 a.m. UTC, Adam Treat wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Konsole and Kurt Hindenburg.</div>
<div>By Adam Treat.</div>
<p style="color: grey;"><i>Updated Dec. 10, 2013, 2:13 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implement a new file filter using POSIX Portable Filename Character Set \
along with KDE's mimetype database of file extension blobs that filters text \
matching a POSIX portable pathname and underlines it very much like links.
Info on the character set allowed can be found at this link:
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_267</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on my local system with a chromium code base and displaying all \
the local files therein and displaying in konsole and opening via filter in \
kate.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.ui <span style="color: grey">(82298cf)</span></li>
<li>src/Filter.h <span style="color: grey">(cbcc8e2)</span></li>
<li>src/Filter.cpp <span style="color: grey">(5818054)</span></li>
<li>src/SessionController.h <span style="color: grey">(2ff7910)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(62c1d0b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114376/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic