'Re: [Konsole-devel] Review Request 114147: Unset pointing hand cursor if set and not over a link'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request 114147: Unset pointing hand cursor if set and not over a link
From:       "Martin Tobias Holmedahl Sandsmark" <martin.sandsmark () kde ! org>
Date:       2013-11-27 10:44:52
Message-ID: 20131127104452.26297.12214 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114147/#review44563
-----------------------------------------------------------

Ship it!

Ship It!

- Martin Tobias Holmedahl Sandsmark

On Nov. 26, 2013, 10:15 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114147/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2013, 10:15 p.m.)
> 
> 
> Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Without this patch if i do this:
>  * Mouse over a link
>  * Press control
>  * Move mouse still over link
>  * Release control
>  * Mouse move outside link
> the mouse pointer is still a pointing hand.
> 
> 
> Diffs
> -----
> 
>   src/TerminalDisplay.cpp bfcf78e 
> 
> Diff: http://git.reviewboard.kde.org/r/114147/diff/
> 
> 
> Testing
> -------
> 
> My testcase now works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114147/">http://git.reviewboard.kde.org/r/114147/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Martin Tobias Holmedahl Sandsmark</p>

<br />
<p>On November 26th, 2013, 10:15 p.m. UTC, Albert Astals Cid wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl \
Sandsmark.</div> <div>By Albert Astals Cid.</div>

<p style="color: grey;"><i>Updated Nov. 26, 2013, 10:15 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">Without this patch if i do this:
 * Mouse over a link
 * Press control
 * Move mouse still over link
 * Release control
 * Mouse move outside link
the mouse pointer is still a pointing hand.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">My testcase now works</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/TerminalDisplay.cpp <span style="color: grey">(bfcf78e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114147/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 