'Re: [Konsole-devel] Review Request 109558: Add --fallback-profile option'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request 109558: Add --fallback-profile option
From:       "Commit Hook" <null () kde ! org>
Date:       2013-04-06 17:45:50
Message-ID: 20130406174550.30398.72520 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109558/#review30575
-----------------------------------------------------------

This review has been submitted with commit cb4ca01e8bed9de8fc27236317f02342ebbbc754 \
by Kurt Hindenburg to branch master.

- Commit Hook

On March 18, 2013, 1:56 a.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109558/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 1:56 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> a user on   IRC accidently put pwd in as the command in the default profile.  When \
> he restarted konsole, it would open, do 'pwd' and close. 
> This adds --fallback-profile which is a shortcut for 'konsole --profile FALLBACK/' \
> which no one would remember. 
> 
> Diffs
> -----
> 
> src/Application.cpp dbf6622 
> src/main.cpp 0468cc6 
> 
> Diff: http://git.reviewboard.kde.org/r/109558/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109558/">http://git.reviewboard.kde.org/r/109558/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit cb4ca01e8bed9de8fc27236317f02342ebbbc754 by Kurt Hindenburg to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On March 18th, 2013, 1:56 a.m. UTC, Kurt Hindenburg wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Konsole.</div>
<div>By Kurt Hindenburg.</div>

<p style="color: grey;"><i>Updated March 18, 2013, 1:56 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">a user on   IRC accidently put pwd in as the command in the default \
profile.  When he restarted konsole, it would open, do &#39;pwd&#39; and close.

This adds --fallback-profile which is a shortcut for &#39;konsole --profile \
FALLBACK/&#39; which no one would remember.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/Application.cpp <span style="color: grey">(dbf6622)</span></li>

 <li>src/main.cpp <span style="color: grey">(0468cc6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109558/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 