[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request: Implement Shift+click to extend selection
From: "Kurt Hindenburg" <kurt.hindenburg () gmail ! com>
Date: 2012-12-23 18:12:35
Message-ID: 20121223181235.14342.27405 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107566/#review23919
-----------------------------------------------------------
Has anyone had time to test this? It seems to work OK in my testing.
- Kurt Hindenburg
On Dec. 3, 2012, 2:48 p.m., Kurt Hindenburg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107566/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2012, 2:48 p.m.)
>
>
> Review request for Konsole.
>
>
> Description
> -------
>
> This is some quick code to implement Shift+Click to extend the selection. Some \
> other terminal support it. I'm not sure if the menu item should be reinstated as \
> well (bug 181986).
>
> This addresses bug 123755.
> http://bugs.kde.org/show_bug.cgi?id=123755
>
>
> Diffs
> -----
>
> src/TerminalDisplay.cpp 871dc9f4da5c45209eccdfee5bd893ec832a3ba0
>
> Diff: http://git.reviewboard.kde.org/r/107566/diff/
>
>
> Testing
> -------
>
> This has NOT been testing very much - I just wanted to see how difficult it would \
> be and didn't want to lose this code.
>
> Thanks,
>
> Kurt Hindenburg
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107566/">http://git.reviewboard.kde.org/r/107566/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Has anyone had time to \
test this? It seems to work OK in my testing.</pre> <br />
<p>- Kurt</p>
<br />
<p>On December 3rd, 2012, 2:48 p.m., Kurt Hindenburg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Konsole.</div>
<div>By Kurt Hindenburg.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2012, 2:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is some quick code to implement Shift+Click to extend the \
selection. Some other terminal support it. I'm not sure if the menu item should \
be reinstated as well (bug 181986).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This has NOT been testing very much - I just wanted to see how difficult \
it would be and didn't want to lose this code.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=123755">123755</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/TerminalDisplay.cpp <span style="color: \
grey">(871dc9f4da5c45209eccdfee5bd893ec832a3ba0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107566/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic