'Re: [Konsole-devel] Review Request: add option to disable ctrl+<mouse wheel> zooming.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: add option to disable ctrl+<mouse wheel> zooming.
From:       "Yichao Yu" <yyc1992 () gmail ! com>
Date:       2012-11-10 20:02:10
Message-ID: 20121110200210.14384.32188 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107281/
-----------------------------------------------------------

(Updated Nov. 10, 2012, 8:02 p.m.)

Review request for Konsole.

Description
-------

The built-in behavior of Ctrl+<Mouse Wheel> to zoom in/out the terminal is =
annoy sometimes and cannot be disabled. This patch adds an option to disabl=
e this behavior. (Default to the original behavior).

Diffs
-----

  src/EditProfileDialog.h c85bd11 =

  src/EditProfileDialog.cpp 8e44df6 =

  src/EditProfileDialog.ui 45eafcc =

  src/Profile.h f14d3a2 =

  src/Profile.cpp e81433f =

  src/TerminalDisplay.h 8e246b8 =

  src/TerminalDisplay.cpp 871dc9f =

  src/ViewManager.cpp faa1395 =

Diff: http://git.reviewboard.kde.org/r/107281/diff/

Testing
-------

Compiled, installed.
Default is not affected.
After disabled the option, Ctrl+<Mouse Wheel> will not cause terminal zoomi=
ng and the zooming is back after re-enabled it.

Thanks,

Yichao Yu

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107281/">http://git.reviewboard.kde.org/r/107281/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Konsole.</div>
<div>By Yichao Yu.</div>

<p style="color: grey;"><i>Updated Nov. 10, 2012, 8:02 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The built-in behavior of Ctrl+&lt;Mouse Wheel&gt; to zoom in/out the \
terminal is annoy sometimes and cannot be disabled. This patch adds an option to \
disable this behavior. (Default to the original behavior). </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled, installed. Default is not affected.
After disabled the option, Ctrl+&lt;Mouse Wheel&gt; will not cause terminal zooming \
and the zooming is back after re-enabled it. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/EditProfileDialog.h <span style="color: grey">(c85bd11)</span></li>

 <li>src/EditProfileDialog.cpp <span style="color: grey">(8e44df6)</span></li>

 <li>src/EditProfileDialog.ui <span style="color: grey">(45eafcc)</span></li>

 <li>src/Profile.h <span style="color: grey">(f14d3a2)</span></li>

 <li>src/Profile.cpp <span style="color: grey">(e81433f)</span></li>

 <li>src/TerminalDisplay.h <span style="color: grey">(8e246b8)</span></li>

 <li>src/TerminalDisplay.cpp <span style="color: grey">(871dc9f)</span></li>

 <li>src/ViewManager.cpp <span style="color: grey">(faa1395)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107281/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 