'Re: [Konsole-devel] Review Request: Add process info gathering support on OpenBSD'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Add process info gathering support on OpenBSD
From:       "Vadim Zhukov" <persgray () gmail ! com>
Date:       2012-10-04 10:47:07
Message-ID: 20121004104707.9181.33641 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106129/
-----------------------------------------------------------

(Updated Oct. 4, 2012, 10:47 a.m.)

Review request for Konsole and Jekyll Wu.

Changes
-------

Update description after recent changes.

Description (updated)
-------

ATM Konsole does not support gathering process information on OpenBSD. I've=
 a patch adding such support.
The first idea was to extend already existing FreeBSDProcessInfo class. I r=
enamed it to a BSDProcessInfo and added a few #ifs here and there. After so=
me input I've created separate OpenBSDProcessInfo class based on FreeBSDPro=
cessInfo code.

I've also fixed a few nits regarding calling C routines (prepended "::" to =
sysctl() and such; added kWarning() printouts if they fail) in new code. If=
 needed I can do them as a separate diff.

Diffs
-----

  src/ProcessInfo.cpp 32c86b1 =

Diff: http://git.reviewboard.kde.org/r/106129/diff/

Testing
-------

On OpenBSD-CURRENT.

Thanks,

Vadim Zhukov

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106129/">http://git.reviewboard.kde.org/r/106129/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Konsole and Jekyll Wu.</div>
<div>By Vadim Zhukov.</div>

<p style="color: grey;"><i>Updated Oct. 4, 2012, 10:47 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Update description after recent changes.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ATM Konsole does not support gathering process information on OpenBSD. \
I&#39;ve a patch adding such support. The first idea was to extend already existing \
FreeBSDProcessInfo class. I renamed it to a BSDProcessInfo and added a few #ifs here \
and there. After some input I&#39;ve created separate OpenBSDProcessInfo class based \
on FreeBSDProcessInfo code.

I&#39;ve also fixed a few nits regarding calling C routines (prepended &quot;::&quot; \
to sysctl() and such; added kWarning() printouts if they fail) in new code. If needed \
I can do them as a separate diff.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">On OpenBSD-CURRENT.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/ProcessInfo.cpp <span style="color: grey">(32c86b1)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106129/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 