'Re: [Konsole-devel] Review Request: Add process info gathering support on OpenBSD'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Add process info gathering support on OpenBSD
From:       "Vadim Zhukov" <persgray () gmail ! com>
Date:       2012-08-23 19:29:26
Message-ID: 20120823192926.12981.44308 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106129/
-----------------------------------------------------------

(Updated Aug. 23, 2012, 7:29 p.m.)

Review request for Konsole and Jekyll Wu.

Changes
-------

Add missing kInfoProc==NULL check after malloc().
In case anyone asking, previous (pre-patch) code dealt wrong with mibLength as it's \
in bytes, not in items. And I see no reason to throw out-of-memory exception via \
operator new - getting process info is not that critical.

Description
-------

ATM Konsole does not support gathering process information on OpenBSD. I've a patch \
adding such support. The main idea is to extend already existing FreeBSDProcessInfo \
class. I renamed it to a BSDProcessInfo and added a few #ifs here and there. If \
that's not desirable, I could create separate OpenBSDProcessInfo class.

I've also fixed a few nits regarding calling C routines (prepended "::" to sysctl() \
and such; added kWarning() printouts if they fail). If needed I can do them as a \
separate diff.

Diffs (updated)
-----

  src/ProcessInfo.cpp 32c86b1 

Diff: http://git.reviewboard.kde.org/r/106129/diff/

Testing
-------

On OpenBSD-CURRENT.

Thanks,

Vadim Zhukov

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106129/">http://git.reviewboard.kde.org/r/106129/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Konsole and Jekyll Wu.</div>
<div>By Vadim Zhukov.</div>

<p style="color: grey;"><i>Updated Aug. 23, 2012, 7:29 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add missing kInfoProc==NULL check after malloc(). In case anyone asking, \
previous (pre-patch) code dealt wrong with mibLength as it&#39;s in bytes, not in \
items. And I see no reason to throw out-of-memory exception via operator new - \
getting process info is not that critical.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ATM Konsole does not support gathering process information on OpenBSD. \
I&#39;ve a patch adding such support. The main idea is to extend already existing \
FreeBSDProcessInfo class. I renamed it to a BSDProcessInfo and added a few #ifs here \
and there. If that&#39;s not desirable, I could create separate OpenBSDProcessInfo \
class.

I&#39;ve also fixed a few nits regarding calling C routines (prepended &quot;::&quot; \
to sysctl() and such; added kWarning() printouts if they fail). If needed I can do \
them as a separate diff.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">On OpenBSD-CURRENT.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/ProcessInfo.cpp <span style="color: grey">(32c86b1)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106129/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 