'[Konsole-devel] Review Request: Change the "Bold" key of ColorScheme from boolean to tri-state'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    [Konsole-devel] Review Request: Change the "Bold" key of ColorScheme from boolean to tri-state
From:       "Jekyll Wu" <adaptee () gmail ! com>
Date:       2012-04-15 11:35:37
Message-ID: 20120415113537.4244.69661 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104605/
-----------------------------------------------------------

Review request for Konsole.

Description
-------

Tha patch is trivial. Konsole now supports "Bold=true", "Bold=false" and other \
values(which all mean using Character::UseCurrentFormat).

However, I just wonder how useful this per-color boldness controlling could be. We \
already have the "BoldIntense" per-profile option to enable or disable boldness. Do \
we need two levels of boldness control: per-profile and per-color in each \
colorscheme?

This addresses bug 168300.
    http://bugs.kde.org/show_bug.cgi?id=168300

Diffs
-----

  src/ColorScheme.cpp 1acb4d4 

Diff: http://git.reviewboard.kde.org/r/104605/diff/

Testing
-------

Thanks,

Jekyll Wu

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104605/">http://git.reviewboard.kde.org/r/104605/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tha patch is trivial. Konsole now supports &quot;Bold=true&quot;, \
&quot;Bold=false&quot; and other values(which all mean using \
Character::UseCurrentFormat).

However, I just wonder how useful this per-color boldness controlling could be. We \
already have the &quot;BoldIntense&quot; per-profile option to enable or disable \
boldness. Do we need two levels of boldness control: per-profile and per-color in \
each colorscheme? </pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=168300">168300</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/ColorScheme.cpp <span style="color: grey">(1acb4d4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104605/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 