[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    [Konsole-devel] [Bug 198175] Konsole should set blur region for the new kwin effect
From:       Eike Hein <hein () kde ! org>
Date:       2012-04-04 6:59:05
Message-ID: bug-198175-5030-P1rpAPJZbR () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=198175

--- Comment #30 from Eike Hein <hein@kde.org> ---
Hugo's patch is incomplete for other reasons I mentioned in a ReviewBoard
thread once, but apparently not here, so I'll repeat them so they are not
forgotten:

The blur region is a per-window atom, but due to the existence of the Konsole
KPart component, Konsole terminal widgets can be hosted in application windows
other than Konsole's own. That means that when setting the blur region, the
Konsole blur code needs to first get the current value of the blur region and
merge the update to be done with that current value, since the hosting
application may be blurring other parts of its window. Of course, the hosting
application also has to do the same on its side.

Further, due to the existence of split support both in Konsole and other apps
using its Konsole KPart component (e.g. Yakuake) or the KPart often being used
in dock widgets (Dolphin, Kate, KDevelop) the size and position of a terminal
within its hosting window can change at any time. That means the blur region
also has to be updated on size and position changes of terminal widgets.

Further, both Konsole and applications hosting the KPart implement a tabbed
interface, and dock widgets can be closed, etc. So the blur region also has to
be updated on show and hide events for terminal widgets.

What existing patches do so far is set the entire "terminal area" in the
Konsole main app window to be blurred. This works for Konsole, but not for apps
using the KPart component, and it actually stops working even for Konsole as
soon as blurring is made a profile option, because then you create the
potential for terminals with and without blur co-existing in tab and/or split
setups, making the requirements the same as for the KPart.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]