'Re: [Konsole-devel] Review Request: Remove the left over code for supporting the 'scroll lock' key'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Remove the left over code for supporting the 'scroll lock' key
From:       "Kurt Hindenburg" <kurt.hindenburg () gmail ! com>
Date:       2012-03-04 23:30:45
Message-ID: 20120304233045.31435.42618 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104156/#review11134
-----------------------------------------------------------

Ship it!

Wow, I didn't realize all that was unused code... nice job.  Thanks.

- Kurt Hindenburg

On March 4, 2012, 11:08 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104156/
> -----------------------------------------------------------
> 
> (Updated March 4, 2012, 11:08 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> See http://lists.kde.org/?l=konsole-devel&m=133090213212458&w=2
> 
> 
> This addresses bug 172271.
>     http://bugs.kde.org/show_bug.cgi?id=172271
> 
> 
> Diffs
> -----
> 
>   data/keyboard-layouts/default.keytab fd8343b 
>   data/keyboard-layouts/linux.keytab c0fe444 
>   data/keyboard-layouts/vt420pc.keytab ee6aa9a 
>   src/CMakeLists.txt e04edf4 
>   src/Emulation.h 8390a25 
>   src/KeyboardTranslator.h 6685e0e 
>   src/KeyboardTranslator.cpp b41c461 
>   src/Pty.h 65b03b2 
>   src/Pty.cpp 8a98de6 
>   src/Session.cpp 97137fd 
>   src/Vt102Emulation.h 1311cdd 
>   src/Vt102Emulation.cpp de32ce8 
>   src/XKB.cpp 4b928e2 
>   src/config-konsole.h.cmake cf3b5e7 
> 
> Diff: http://git.reviewboard.kde.org/r/104156/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104156/">http://git.reviewboard.kde.org/r/104156/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wow, I didn&#39;t \
realize all that was unused code... nice job.  Thanks.</pre>  <br />

<p>- Kurt</p>

<br />
<p>On March 4th, 2012, 11:08 p.m., Jekyll Wu wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>

<p style="color: grey;"><i>Updated March 4, 2012, 11:08 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">See http://lists.kde.org/?l=konsole-devel&amp;m=133090213212458&amp;w=2</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=172271">172271</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>data/keyboard-layouts/default.keytab <span style="color: \
grey">(fd8343b)</span></li>

 <li>data/keyboard-layouts/linux.keytab <span style="color: \
grey">(c0fe444)</span></li>

 <li>data/keyboard-layouts/vt420pc.keytab <span style="color: \
grey">(ee6aa9a)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(e04edf4)</span></li>

 <li>src/Emulation.h <span style="color: grey">(8390a25)</span></li>

 <li>src/KeyboardTranslator.h <span style="color: grey">(6685e0e)</span></li>

 <li>src/KeyboardTranslator.cpp <span style="color: grey">(b41c461)</span></li>

 <li>src/Pty.h <span style="color: grey">(65b03b2)</span></li>

 <li>src/Pty.cpp <span style="color: grey">(8a98de6)</span></li>

 <li>src/Session.cpp <span style="color: grey">(97137fd)</span></li>

 <li>src/Vt102Emulation.h <span style="color: grey">(1311cdd)</span></li>

 <li>src/Vt102Emulation.cpp <span style="color: grey">(de32ce8)</span></li>

 <li>src/XKB.cpp <span style="color: grey">(4b928e2)</span></li>

 <li>src/config-konsole.h.cmake <span style="color: grey">(cf3b5e7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104156/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 