[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request: konsolepart should not provide meaningless action to its host
From: "Commit Hook" <null () kde ! org>
Date: 2012-03-01 1:02:14
Message-ID: 20120301010214.25222.8161 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104034/#review11043
-----------------------------------------------------------
This review has been submitted with commit 08de49da1cf4c89c375d7eea267bce3b46c05527 \
by Jekyll Wu to branch master.
- Commit Hook
On Feb. 20, 2012, 7:55 p.m., Jekyll Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104034/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2012, 7:55 p.m.)
>
>
> Review request for Konsole and Eike Hein.
>
>
> Description
> -------
>
> What the patch does is simple: for class SessionController, provide less actions \
> for konsolepart and more actions for stand-alone konsole.
> This is not a good solution for the reported problem, but I think it at least makes \
> the situation better.
> Below is simple explanations for not providing those actions:
>
> copy-input-to-all-tabs
> copy-input-to-selected-tabs
> copy-input-to-none
>
> Since konsolepart currently does not provide tabbar and tabs, those actions are \
> meaningless for konsolepart.
> rename-session
>
> Since konsolepart does not support tabbar, this action is not that useful. Yakuake \
> has its own action for renaming.
> zmodem-upload
>
> Not quite sure about this. I just guess this feature is not widely used.
>
> monitor-activity
> monitor-silence
>
> Not quite sure, either. My general tendency is remove most actions not included in \
> the context menu at this moment.
> set-encoding
>
> No entry within context menu(Although I'm confuse why), no default shortcut; why \
> provide this action in konsolepart?
> enlarge-font
> shrink-font
>
> Three unconfigurable shortcuts are involved. Better not provide them until the \
> actions provided by konsolepart are configurable and konsolepart loads customized \
> shortcuts.
>
> The 3 actions related with "Find"
>
> Before konsolepart supports searching, those actions are meaningless for \
> konsolepart.
>
>
>
>
> This addresses bug 248469.
> http://bugs.kde.org/show_bug.cgi?id=248469
>
>
> Diffs
> -----
>
> src/SessionController.h 2382023
> src/SessionController.cpp d09a0fd
>
> Diff: http://git.reviewboard.kde.org/r/104034/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jekyll Wu
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104034/">http://git.reviewboard.kde.org/r/104034/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 08de49da1cf4c89c375d7eea267bce3b46c05527 by Jekyll Wu to branch \
master.</pre> <br />
<p>- Commit</p>
<br />
<p>On February 20th, 2012, 7:55 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Konsole and Eike Hein.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2012, 7:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">What the patch does is simple: for class SessionController, provide less \
actions for konsolepart and more actions for stand-alone konsole.
This is not a good solution for the reported problem, but I think it at least makes \
the situation better.
Below is simple explanations for not providing those actions:
copy-input-to-all-tabs
copy-input-to-selected-tabs
copy-input-to-none
Since konsolepart currently does not provide tabbar and tabs, those actions are \
meaningless for konsolepart.
rename-session
Since konsolepart does not support tabbar, this action is not that useful. Yakuake \
has its own action for renaming.
zmodem-upload
Not quite sure about this. I just guess this feature is not widely used.
monitor-activity
monitor-silence
Not quite sure, either. My general tendency is remove most actions not included in \
the context menu at this moment.
set-encoding
No entry within context menu(Although I'm confuse why), no default shortcut; \
why provide this action in konsolepart?
enlarge-font
shrink-font
Three unconfigurable shortcuts are involved. Better not provide them until the \
actions provided by konsolepart are configurable and konsolepart loads customized \
shortcuts.
The 3 actions related with "Find"
Before konsolepart supports searching, those actions are meaningless for \
konsolepart.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=248469">248469</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/SessionController.h <span style="color: grey">(2382023)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(d09a0fd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104034/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic