--===============8940262428587469203==
Content-Type: multipart/alternative; boundary=00235447046cfb23b604b9ad9b64

--00235447046cfb23b604b9ad9b64
Content-Type: text/plain; charset=UTF-8

On Thu, Feb 23, 2012 at 1:06 PM, Jekyll Wu <adaptee@gmail.com> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Well, that dialog is a little messy in several aspects at the moment:
>
> 1). It uses QTabWidget, which is deprecated according to the krazy
> report[1]. Although I'm not clear why QTabWidget is deprecated, the
> appearance of that dialog looks really outdated when compared with
> most other KDE applications.
>
Again, it has been a while since I looked at this.  I believe w/ KTabWidget
you get all the styles that make it look like the rest of KDE.

>
> That appearance problem is more obvious now that we have the "Config
> Konsole" dialog, which is similar to dialogs in other KDE
> applications. I guess users will have similar feeling in next major
> release.
>
> What shall we do ?
>
I thought perhaps we might try (perhaps a mockup) to put the edit dialog
combined w/ configure dialog.  But really, anything would likely be better.

>
> 2). It costs too much code. The file EditProfileDialog.cpp contains
> almost 1400 lines of code. This is probably due to that it contains
> many customized behavior. But still it contains too much code, and the
> codes are just cluttered together within one big file. This is bad not
> only for existing developers to maintain the code, but also for random
> contributors to figure out where to start with.
>
> This problem also applies to other files. The best/worst example is
> TerminalDisplay.cpp, which contains 3000 lines of code. I have to
> admit that number often scares me ...
>
> What shall we do ?
>
You're more than welcomed to try to separate the classes.  I rarely have
time to do anything but try to keep up w/ bug reports and serious bugs.
 Something this big would take serious design and time.  A remote branch
would be the way to go here.

>
> 3). It uses the home made class Konsole::WarningBox to show warning
> message. That increase the maintenance burden and provide inconsistent
> appearance.
>
> That's fine.  I look at it a while for the control dialog (ctrl+s/q) and
didn't like it since it changed the dimensions of the terminal (like the
search bar did).  You're patch is fine.


> Again, thanks for your work on Konsole

   Kurt

--00235447046cfb23b604b9ad9b64
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<font size=3D"4"><font face=3D"georgia,serif"><br></font></font><br><div cl=
ass=3D"gmail_quote">On Thu, Feb 23, 2012 at 1:06 PM, Jekyll Wu <span dir=3D=
"ltr">&lt;<a href=3D"mailto:adaptee@gmail.com">adaptee@gmail.com</a>&gt;</s=
pan> wrote:<br>

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<br>
Well, that dialog is a little messy in several aspects at the moment:<br>
<br>
1). It uses QTabWidget, which is deprecated according to the krazy<br>
report[1]. Although I&#39;m not clear why QTabWidget is deprecated, the<br>
appearance of that dialog looks really outdated when compared with<br>
most other KDE applications.<br></blockquote><div>Again, it has been a whil=
e since I looked at this. =C2=A0I believe w/ KTabWidget you get all the sty=
les that make it look like the rest of KDE.=C2=A0</div><blockquote class=3D=
"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding=
-left:1ex">


<br>
That appearance problem is more obvious now that we have the &quot;Config<b=
r>
Konsole&quot; dialog, which is similar to dialogs in other KDE<br>
applications. I guess users will have similar feeling in next major<br>
release.<br>
<br>
What shall we do ?<br></blockquote><div>I thought perhaps we might try (per=
haps a mockup) to put the edit dialog combined w/ configure dialog. =C2=A0B=
ut really, anything would likely be better.</div><blockquote class=3D"gmail=
_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:=
1ex">


<br>
2). It costs too much code. The file EditProfileDialog.cpp contains<br>
almost 1400 lines of code. This is probably due to that it contains<br>
many customized behavior. But still it contains too much code, and the<br>
codes are just cluttered together within one big file. This is bad not<br>
only for existing developers to maintain the code, but also for random<br>
contributors to figure out where to start with.<br>
<br>
This problem also applies to other files. The best/worst example is<br>
TerminalDisplay.cpp, which contains 3000 lines of code. I have to<br>
admit that number often scares me ...<br>
<br>
What shall we do ?<br></blockquote><div>You&#39;re more than welcomed to tr=
y to separate the classes. =C2=A0I rarely have time to do anything but try =
to keep up w/ bug reports and serious bugs. =C2=A0Something this big would =
take serious design and time. =C2=A0A remote branch would be the way to go =
here.=C2=A0</div>

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
<br>
3). It uses the home made class Konsole::WarningBox to show warning<br>
message. That increase the maintenance burden and provide inconsistent<br>
appearance.<br>
<br></blockquote><div>That&#39;s fine. =C2=A0I look at it a while for the c=
ontrol dialog (ctrl+s/q) and didn&#39;t like it since it changed the dimens=
ions of the terminal (like the search bar did). =C2=A0You&#39;re patch is f=
ine.</div>

<div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8=
ex;border-left:1px #ccc solid;padding-left:1ex">Again, thanks for your work=
 on Konsole</blockquote><div>=C2=A0 =C2=A0Kurt</div><div>=C2=A0</div></div>

--00235447046cfb23b604b9ad9b64--

--===============8940262428587469203==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

--===============8940262428587469203==--