'Re: [Konsole-devel] Review Request: Allow changing tab title through escape sequence'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Allow changing tab title through escape sequence
From:       "Kurt Hindenburg" <kurt.hindenburg () gmail ! com>
Date:       2012-02-24 3:38:41
Message-ID: 20120224033841.31393.19268 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103862/#review10862
-----------------------------------------------------------

Ship it!

Ship It!

- Kurt Hindenburg

On Feb. 4, 2012, 8:17 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103862/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2012, 8:17 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> It seems KDE3 konsole provided the ability of changing tab title through escape sequence such as :
> 
>     echo -en "\e]30;Set Tab Name\a" 
> 
> , and quite some users miss this feature in KDE4 konsole.
> 
> So I made a little patch(or hack?) to get this feature back.
> 
> Frankly, I'm not a fan of this feature. 
> 
> 
> This addresses bug 179142.
>     http://bugs.kde.org/show_bug.cgi?id=179142
> 
> 
> Diffs
> -----
> 
>   src/Session.cpp c8f33d4 
> 
> Diff: http://git.reviewboard.kde.org/r/103862/diff/
> 
> 
> Testing
> -------
> 
> It seems to work as in KDE3 konsole. I'm not sure
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103862/">http://git.reviewboard.kde.org/r/103862/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Kurt</p>

<br />
<p>On February 4th, 2012, 8:17 a.m., Jekyll Wu wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>

<p style="color: grey;"><i>Updated Feb. 4, 2012, 8:17 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It seems KDE3 konsole provided the ability of changing tab title through \
escape sequence such as :

    echo -en &quot;\e]30;Set Tab Name\a&quot; 

, and quite some users miss this feature in KDE4 konsole.

So I made a little patch(or hack?) to get this feature back.

Frankly, I&#39;m not a fan of this feature. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It seems to work as in KDE3 konsole. I&#39;m not sure</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=179142">179142</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/Session.cpp <span style="color: grey">(c8f33d4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103862/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 