-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Well, that dialog is a little messy in several aspects at the moment:

1). It uses QTabWidget, which is deprecated according to the krazy
report[1]. Although I'm not clear why QTabWidget is deprecated, the
appearance of that dialog looks really outdated when compared with
most other KDE applications.

That appearance problem is more obvious now that we have the "Config
Konsole" dialog, which is similar to dialogs in other KDE
applications. I guess users will have similar feeling in next major
release.

What shall we do ?

2). It costs too much code. The file EditProfileDialog.cpp contains
almost 1400 lines of code. This is probably due to that it contains
many customized behavior. But still it contains too much code, and the
codes are just cluttered together within one big file. This is bad not
only for existing developers to maintain the code, but also for random
contributors to figure out where to start with.

This problem also applies to other files. The best/worst example is
TerminalDisplay.cpp, which contains 3000 lines of code. I have to
admit that number often scares me ...

What shall we do ?

3). It uses the home made class Konsole::WarningBox to show warning
message. That increase the maintenance burden and provide inconsistent
appearance.

I think we can consider using the recently added KMessageWidget[2][3]
to replace the home made class. That implies we need to increase the
minimal kdelibs version from 4.6.4 to 4.7

I have play around with KMessageWidget for a while, and the result
seems acceptable. Will create a review request some time later.

[1]
http://ebn.kde.org/krazy/reports/kde-4.x/kde-baseapps/konsole/index.html
[2]
http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKMessageWidget.html
[3] https://git.reviewboard.kde.org/r/101249/


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPRoA4AAoJEOemZ9znWXlASJ4QAJYH9DbgYU8/ZbB2hNFoqwsT
beiwuwte92sifiZQmRetkggRMjWdFo3i1n3M3px8qYM+RHw5TUbZ7Fv37BfRjbqF
mLkD7wDgLrxzv1Hsz++HYBr1zolxn1Y+o9/zv/zoR4XXQ+X6kti1rrBcVyWfcV0K
yKIdjvvKvUBb9m+bVynNVMNWBFUvFBeuLUWrPg3P79ISTLOy7DnmsxwHVR/w3BUd
9Ykf4/XN1j0uYHJFUHGt8cSsIL1mJIQYGp7NrJCjl9Up2cXaWvt/MrhH4NByaZgG
jBQwRo7QnSRrlo1AE0Z7Ij1lvTYnjwo+4istPzmL/c5oHO/cZA63bCHe4vYoVyOL
BiBAV4eLl+YnymBOZN5htJUUhD0Gwj4VZLbDyB+Fp9DFkCWG+Fawss6039FcTugf
ycX0R5joXX85Bdaz/lqf+AtDBgSYXCW0/DR6DxvInii7I/3nkrEbqFOgDDKUlMAW
+v0cC8/iMatdSEP6fMeGvTWCkDddBav9/OmdeGSvIZUrJd6B0Z5A9BNTFsIhC71U
7fdFirNr37VG4xcM69VrVdjp3OxsLjXylxbv6xzdfg7RK6YKHPeAY0MtoHIJ8ANC
lgNwU67K/qde7+avSDtz5Iez1e16cKR75u0pT9RLygkDzRznnXMfdnHvn+bV+JYi
gwNfI3hraWgb3bPwkON3
=LenK
-----END PGP SIGNATURE-----
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel