'[Konsole-devel] Review Request: Change the default shortcut for'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    [Konsole-devel] Review Request: Change the default shortcut for
From:       "Jekyll Wu" <adaptee () gmail ! com>
Date:       2012-01-09 18:51:27
Message-ID: 20120109185127.31907.83339 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103660/
-----------------------------------------------------------

Review request for Konsole.

Description
-------

I think the bug report is quite sensible. Scrollback is an important asset, but it \
can't be recovered once gone. So I think it is a good idea to reduce the chance of \
losing scrollback due to accidental operation.

The pros and cons of choosing  Ctrl + Shift + K

pros: it is easy to press , good for the wrist of left hand

cons: it require two hands. But that should not be a big problem since having both \
hands on keyboard is the normal case when using konsole.  
Actually, I think Ctrl + Alt + K is even better. But it seems most default shortcuts \
use the combination of 'Ctrl + Shift'.

This addresses bug 282593.
    http://bugs.kde.org/show_bug.cgi?id=282593

Diffs
-----

  src/SessionController.cpp 60d3f36 

Diff: http://git.reviewboard.kde.org/r/103660/diff/diff

Testing
-------

Thanks,

Jekyll Wu

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103660/">http://git.reviewboard.kde.org/r/103660/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I think the bug report is quite sensible. Scrollback is an important \
asset, but it can&#39;t be recovered once gone. So I think it is a good idea to \
reduce the chance of losing scrollback due to accidental operation.

The pros and cons of choosing  Ctrl + Shift + K

pros: it is easy to press , good for the wrist of left hand

cons: it require two hands. But that should not be a big problem since having both \
hands on keyboard is the normal case when using konsole.  
Actually, I think Ctrl + Alt + K is even better. But it seems most default shortcuts \
use the combination of &#39;Ctrl + Shift&#39;.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=282593">282593</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/SessionController.cpp <span style="color: grey">(60d3f36)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103660/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 