[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request: Make 'Shift+Insert" work in
From: "Peter Penz" <peter.penz19 () gmail ! com>
Date: 2011-10-20 18:56:23
Message-ID: 20111020185623.14906.81370 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102924/#review7513
-----------------------------------------------------------
Ship it!
> From a Dolphin point-of-view this patch is fine. I cannot judge whether from the \
> perspective of the terminal-interface this patch is more a workaround or just a \
> pragmatic solution, but judging from the recent commits you seem to maintain \
> konsole anyhow so it's on you to decide :-) Thanks for taking care of this issue!
- Peter Penz
On Oct. 20, 2011, 9:50 a.m., Jekyll Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102924/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2011, 9:50 a.m.)
>
>
> Review request for Konsole and Peter Penz.
>
>
> Description
> -------
>
> When 'Shift+Insert' is pressed, konsole currently sends the \
> 'overrideShortcutCheck(bool&)' signal to ask higher level whether this key \
> combination should always go into the terminal process (thus overriding shortcut).
> In stand-alone konsole, the higher level never answer such question, so the key \
> combination may be intercepted as shortcut.
> The konsole kpart, however, answers such question as: " such key combination should \
> always go into terminal process". Of course, the host apps can override that \
> decision. The unfortunate fact is most host apps do not. AFAIK, yakuake is the only \
> host app which answer this question itself. So dolphin, kate, okteta, an kdevelop \
> all suffer from this 'Shift+Insert' problem, while yakuake does not.
> The problem has at least two solutions:
>
> 1). konsole code treats "Shift+Insert" specially, since that is conventionally used \
> as the shortcut for pasting and deserves such special treatment. That is what this \
> patch does.
> 2). All host apps answer that question themselves, and treat Shift+Insert specially \
> there. I guess most host apps just do not like this solution.
>
> This addresses bug 165720.
> http://bugs.kde.org/show_bug.cgi?id=165720
>
>
> Diffs
> -----
>
> src/TerminalDisplay.cpp 54abc14
>
> Diff: http://git.reviewboard.kde.org/r/102924/diff/diff
>
>
> Testing
> -------
>
> 'Shift+Insert' works in dolphin,kate,okteta,kdevelop. No regression observed so far
>
>
> Thanks,
>
> Jekyll Wu
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102924/">http://git.reviewboard.kde.org/r/102924/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From a Dolphin \
point-of-view this patch is fine. I cannot judge whether from the perspective of the \
terminal-interface this patch is more a workaround or just a pragmatic solution, but \
judging from the recent commits you seem to maintain konsole anyhow so it's on \
you to decide :-) Thanks for taking care of this issue!</pre> <br />
<p>- Peter</p>
<br />
<p>On October 20th, 2011, 9:50 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Konsole and Peter Penz.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Oct. 20, 2011, 9:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When 'Shift+Insert' is pressed, konsole currently sends the \
'overrideShortcutCheck(bool&)' signal to ask higher level whether this \
key combination should always go into the terminal process (thus overriding \
shortcut).
In stand-alone konsole, the higher level never answer such question, so the key \
combination may be intercepted as shortcut.
The konsole kpart, however, answers such question as: " such key combination \
should always go into terminal process". Of course, the host apps can override \
that decision. The unfortunate fact is most host apps do not. AFAIK, yakuake is the \
only host app which answer this question itself. So dolphin, kate, okteta, an \
kdevelop all suffer from this 'Shift+Insert' problem, while yakuake does not.
The problem has at least two solutions:
1). konsole code treats "Shift+Insert" specially, since that is \
conventionally used as the shortcut for pasting and deserves such special treatment. \
That is what this patch does.
2). All host apps answer that question themselves, and treat Shift+Insert specially \
there. I guess most host apps just do not like this solution. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">'Shift+Insert' works in dolphin,kate,okteta,kdevelop. No \
regression observed so far</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=165720">165720</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/TerminalDisplay.cpp <span style="color: grey">(54abc14)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102924/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic