https://bugs.kde.org/show_bug.cgi?id=157882





--- Comment #22 from Robert Knight <robertknight gmail com>  2011-07-03 13:27:00 ---
Hi Alexandre,

A few comments on the patch:

 * I suggest ColorSchemeWallpaper::_picture should be a QPixmap instead of a
QPixmap*
 * Instead of allocating a special large pixmap to hold the tiled image, you
could just draw it directly when rendering the image.  This will save a
noticeable amount of memory when the terminal window is large.  Pre-rendering
to a pixmap mainly makes sense if you need to apply additional effects or the
initial rendering is especially expensive relative to the cost of drawing a
single pixmap.
 * The coding standard in Konsole is for & and * to bind to the type rather
than the name ('QString&' instead of 'QString &foo')
 * ColorSchemeWallpaper::path() should return a plain QString rather than a
const ref, in keeping with most of the Qt APIs

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel