[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: [Konsole-devel] Review Request: Correct issue where spaces are
From: "Kurt Hindenburg" <kurt.hindenburg () gmail ! com>
Date: 2011-03-22 4:54:14
Message-ID: 20110322045414.21312.18313 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100913/
-----------------------------------------------------------
Review request for Konsole.
Summary
-------
This fixes the issue where spaces are copyable at the end of lines
when the foreground or background colors are non-default.
tput setf 1
When clearing with ' ', the defaultChar will be used.
This will cause the lines to be resized (getting rid of the spaces).
This addresses bug 188528.
http://bugs.kde.org/show_bug.cgi?id=188528
Diffs
-----
src/Screen.cpp 41df716
Diff: http://git.reviewboard.kde.org/r/100913/diff
Testing
-------
work when using 'tput setf #' and 'tput setb #'
and in vim ":hi normal ctermbg=white'
Thanks,
Kurt
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100913/">http://git.reviewboard.kde.org/r/100913/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Konsole.</div>
<div>By Kurt Hindenburg.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes the issue where spaces are copyable at the end of lines when \
the foreground or background colors are non-default. tput setf 1
When clearing with ' ', the defaultChar will be used.
This will cause the lines to be resized (getting rid of the spaces).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">work when using 'tput setf #' and 'tput setb #' and in \
vim ":hi normal ctermbg=white'
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=188528">188528</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Screen.cpp <span style="color: grey">(41df716)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100913/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic