[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    [Konsole-devel] Review Request: Add option to blur transparent
From:       "Arno Rehn" <kde () arnorehn ! de>
Date:       2010-06-13 13:57:43
Message-ID: 20100613135743.27377.43103 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4292/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

This patch adds an option to Konsole's color scheme editor to enable blurring on \
transparent backgrounds. It makes use of the new _KDE_NET_WM_BLUR_BEHIND_REGION Atom \
recognized by KWin. When tabs are switched it checks whether the color scheme of the \
new tab has blurring enabled and enables or disables blurring accordingly.

I know we're in hard feature freeze and string freeze. But to not have this \
forgotten, I'll post it here now.


Diffs
-----

  /trunk/KDE/kdebase/apps/konsole/src/ColorScheme.h 1137325 
  /trunk/KDE/kdebase/apps/konsole/src/ColorScheme.cpp 1137325 
  /trunk/KDE/kdebase/apps/konsole/src/ColorSchemeEditor.h 1137325 
  /trunk/KDE/kdebase/apps/konsole/src/ColorSchemeEditor.cpp 1137325 
  /trunk/KDE/kdebase/apps/konsole/src/ColorSchemeEditor.ui 1137325 
  /trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.h 1137325 
  /trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp 1137325 
  /trunk/KDE/kdebase/apps/konsole/src/ViewManager.cpp 1137325 

Diff: http://reviewboard.kde.org/r/4292/diff


Testing
-------

Tested by switching tabs back and forth, enabling and disabling blurring again and \
again. No crashes so far.


Screenshots
-----------

Konsole with enabled blurring
  http://reviewboard.kde.org/r/4292/s/430/


Thanks,

Arno

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel


[prev in list] [next in list] [prev in thread] [next in thread]