[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    [Konsole-devel] Review Request: Make using bold fonts for intense
From:       "Valentine Sinitsyn" <valentine.sinitsyn () gmail ! com>
Date:       2010-06-01 18:00:16
Message-ID: 20100601180016.7022.43883 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4201/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

It is well known that standard ANSI color codes don't distinguish between bold [font] \
and bright/intense [color], since both of them are controlled with a single escape \
command (m). In KDE3, Konsole was interpreting this command as "make the color \
bright" and leaving font weight untouched. Beginning with KDE4, both color and font \
weight are changed. At the very end, the decision whether or not to make the font \
bold is somewhat matter of taste, and since many fonts available for Linux look ugly \
when they are bold, it is reasonable to leave this decision to the user, making this \
a configurable runtime option.

The patch suggested add such option to the Appearance tab in Edit Profile dialog. \
This is a per-profile setting which defaults to "make fonts bold" for compatibility \
reasons.


This addresses bug 226308.
    https://bugs.kde.org/show_bug.cgi?id=226308


Diffs
-----

  trunk/KDE/kdebase/apps/konsole/src/EditProfileDialog.ui 1133265 
  trunk/KDE/kdebase/apps/konsole/src/EditProfileDialog.cpp 1133265 
  trunk/KDE/kdebase/apps/konsole/src/EditProfileDialog.h 1133265 
  trunk/KDE/kdebase/apps/konsole/src/Profile.h 1133265 
  trunk/KDE/kdebase/apps/konsole/src/Profile.cpp 1133265 
  trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.h 1133265 
  trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp 1133265 
  trunk/KDE/kdebase/apps/konsole/src/ViewManager.cpp 1133265 

Diff: http://reviewboard.kde.org/r/4201/diff


Testing
-------

Yes. Works with KDE 4.4.3 and trunk on my systems


Thanks,

Valentine

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel


[prev in list] [next in list] [prev in thread] [next in thread]