[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Move 'Show Menu Bar' and
From:       "Sascha Peilicke" <sasch.pe () gmx ! de>
Date:       2010-05-02 14:43:51
Message-ID: 20100502144351.2737.80189 () localhost
[Download RAW message or body]



> On 2010-04-27 03:22:03, Kurt Hindenburg wrote:
> > The other issue to keep in mind is the context menu.  It has 'Change Profile', \
> > 'Edit Current Profile...' and Scrollback Options.  All of these you've removed \
> > from the main menu.  I'm not positive removing them was a good idea.   Scrollback \
> > options - sometimes you want to temporary change this and now you have to use the \
> > profile settings. The 'File->Save Output As' - I'm not sure people will \
> > understand what this is for with no context (scrollback). 

Regarding 'Save Output As', maybe 'Save History As' is better?


- Sascha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3110/#review5250
-----------------------------------------------------------


On 2010-03-04 16:56:13, Sascha Peilicke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3110/
> -----------------------------------------------------------
> 
> (Updated 2010-03-04 16:56:13)
> 
> 
> Review request for Konsole, Robert Knight and Kurt Hindenburg.
> 
> 
> Summary
> -------
> 
> I expanded the patch quite a bit to address several issues with the menu bar:
> 
> Replaced KActions with KStandardActions wherever possible for better integration \
> and less reinvented wheels. 
> Move the actions 'Show Menu Bar' and 'Fullscreen Mode' from the 'View' menu to the \
> 'Settings' menu. Those actions are to be found in the settings menu in most other \
> KDE apps. 
> The favorite profiles in the 'File' menu are now sorted under a submenu 'New Tab' \
> together with a new default action 'Default Profile'. The "Close Tab" button moved \
> up to the logical group. 
> 'Save Output' from the 'Scrollback' menu moved to the file menu, which is for \
> loading/saving after all. The 'Search Output', find next and find previous actions \
> where moved to the 'Edit' menu and use KStandardActions. This way it behaves more \
> like in Okular, Dolphin, Konqi... 
> Scrollback options moved to 'Settings' menu and  thus the 'Scrollback' menu was \
> removed. 
> 'Increase/Decrease Font Size' where renamed to 'Enlarge/Shrink Font', like we have \
> in Okular and Konqueror. 
> 'Edit current profile' in the settings menu went away, this is already available \
> via 'Configure Profiles...'. 
> 'Change Profile' in the settings menu went away, this is already available in the \
> session context menu and not really settings. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/apps/konsole/desktop/konsoleui.rc 1098894 
> trunk/KDE/kdebase/apps/konsole/desktop/partui.rc 1098894 
> trunk/KDE/kdebase/apps/konsole/desktop/sessionui.rc 1098894 
> trunk/KDE/kdebase/apps/konsole/src/MainWindow.h 1098894 
> trunk/KDE/kdebase/apps/konsole/src/MainWindow.cpp 1098894 
> trunk/KDE/kdebase/apps/konsole/src/Part.cpp 1098894 
> trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1098894 
> 
> Diff: http://reviewboard.kde.org/r/3110/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
> http://reviewboard.kde.org/r/3110/s/325/
> 
> http://reviewboard.kde.org/r/3110/s/327/
> 
> 
> Thanks,
> 
> Sascha
> 
> 

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel


[prev in list] [next in list] [prev in thread] [next in thread]