[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Allow tab width and text to be
From:       "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date:       2010-01-21 17:11:35
Message-ID: 20100121171135.13130.93349 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2503/#review3778
-----------------------------------------------------------



/trunk/KDE/kdebase/apps/konsole/src/ViewContainer.cpp
<http://reviewboard.kde.org/r/2503/#comment3200>

    As has been mentioned elsewhere, please use a constant rather than a hard-coded number.
    
    Also, please avoid introducing trailing whitespace.


- Matthew


On 2010-01-05 05:17:55, Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2503/
> -----------------------------------------------------------
> 
> (Updated 2010-01-05 05:17:55)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> This changes the hint size for the tab and automatically allows for the tab title to be elided.
> 
> Part of patch is from BR157201
> 
> 
> This addresses bug 157201.
>     https://bugs.kde.org/show_bug.cgi?id=157201
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/src/ViewContainer.cpp 1069228 
> 
> Diff: http://reviewboard.kde.org/r/2503/diff
> 
> 
> Testing
> -------
> 
> Tested under trunk using %d %D with varying folder lengths and tabs.
> 
> I don't care much for the sizeHint code but it works.  May have to redo it.
> 
> 
> Thanks,
> 
> Kurt
> 
>

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]