[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Add process information for
From:       "Robert Knight" <robertknight () gmail ! com>
Date:       2009-08-31 14:12:26
Message-ID: 20090831141226.6239.90635 () localhost
[Download RAW message or body]



> On 2009-08-31 11:43:59, Robert Knight wrote:
> > /trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp, line 635
> > <http://reviewboard.kde.org/r/1485/diff/1/?file=10864#file10864line635>
> > 
> > readEnvironment() should return false if not implemented.
> 
> wrote:
> Actually, I'm returning true both here and in readArguments() after reading the \
> code in SolarisProcessInfo. Should at least SolarisProcessInfo::readEnvironment() \
> return false as well?

Yes, in that case SolarisProcessInfo should be corrected as well.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1485/#review2214
-----------------------------------------------------------


On 2009-08-31 03:58:40, Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1485/
> -----------------------------------------------------------
> 
> (Updated 2009-08-31 03:58:40)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> This patch implements support for FreeBSD in ProcessInfo.cpp, the same way there's \
> support for Mac and Solaris. 
> I'm not a FreeBSD expert (it's not my primary system), so some methods \
> (readEnvironment() and readArguments()) were not implemented, either because I \
> don't know how or because it's not possible in FreeBSD. 
> I also had to use free() in readCurrentDir() because of the way kinfo_getfile() is \
> implemented. 
> Last but not least, when I compile programs that use kinfo_getfile(), I usually \
> have to pass -lutil to gcc; however, everything compiled fine without any changes \
> to CMakeLists.txt. 
> 
> This addresses bug 205648.
> https://bugs.kde.org/show_bug.cgi?id=205648
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp 1017209 
> 
> Diff: http://reviewboard.kde.org/r/1485/diff
> 
> 
> Testing
> -------
> 
> With the patch, using "%u", "%d", "%D", "%n" in tab titles works fine now; \
> previously, I got empty strings. 
> 
> Thanks,
> 
> Raphael
> 
> 

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel


[prev in list] [next in list] [prev in thread] [next in thread]