[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    [Konsole-devel] Review Request: Add process information for FreeBSD
From:       "Raphael Kubo da Costa" <kubito () gmail ! com>
Date:       2009-08-31 3:58:40
Message-ID: 20090831035840.14655.24021 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1485/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

This patch implements support for FreeBSD in ProcessInfo.cpp, the same way there's \
support for Mac and Solaris.

I'm not a FreeBSD expert (it's not my primary system), so some methods \
(readEnvironment() and readArguments()) were not implemented, either because I don't \
know how or because it's not possible in FreeBSD.

I also had to use free() in readCurrentDir() because of the way kinfo_getfile() is \
implemented.

Last but not least, when I compile programs that use kinfo_getfile(), I usually have \
to pass -lutil to gcc; however, everything compiled fine without any changes to \
CMakeLists.txt.


This addresses bug 205648.
    https://bugs.kde.org/show_bug.cgi?id=205648


Diffs
-----

  /trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp 1017209 

Diff: http://reviewboard.kde.org/r/1485/diff


Testing
-------

With the patch, using "%u", "%d", "%D", "%n" in tab titles works fine now; \
previously, I got empty strings.


Thanks,

Raphael

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel


[prev in list] [next in list] [prev in thread] [next in thread]