[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Patch for better visualization
From:       "Thomas Dreibholz" <dreibh () iem ! uni-due ! de>
Date:       2009-07-21 9:52:37
Message-ID: 20090721095237.29358.80097 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1058/
-----------------------------------------------------------

(Updated 2009-07-21 09:52:37.051225)


Review request for Konsole.


Changes
-------

The patch has been updated to use a different icon and the asterisk only.


Summary
-------

konsole only indicates the master mode ("Copy Input To ...") by a small asterisk \
('*'). This can be easily overlooked by the user which can lead to unintended command \
calls in other sessions (e.g. something like "rm -rf ..."). The applied patch makes \
the master mode more visualize by adding "[MASTER]" (or 18n-version) to the title and \
also by changing the icon to "emblem-important" (this may be a good choice to alert \
the user; may be there is something better?).


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/konsole/src/SessionController.h 999292 
  /trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 999292 
  /trunk/KDE/kdebase/apps/konsole/src/main.cpp 999292 

Diff: http://reviewboard.kde.org/r/1058/diff


Testing
-------

Tested with SVN revision 999102.


Thanks,

Thomas

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel


[prev in list] [next in list] [prev in thread] [next in thread]