[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request: Use more standard tab cycle
From: "Robert Knight" <robertknight () gmail ! com>
Date: 2009-07-17 9:16:47
Message-ID: 20090717091647.29457.64169 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1044/#review1643
-----------------------------------------------------------
Ship it!
Looks good to me. Please commit or let me know if you do not have KDE SVN \
account.
- Robert
On 2009-07-17 05:16:03, Jacob Welsh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1044/
> -----------------------------------------------------------
>
> (Updated 2009-07-17 05:16:03)
>
>
> Review request for Konsole.
>
>
> Summary
> -------
>
> Reverses the key mappings so ctrl+pageup goes to the previous tab and \
> ctrl+pagedown goes to the next tab. Other applications with this behavior \
> include firefox and gnome-terminal, and it is more consistent within \
> Konsole since it will match the mouse wheel tab cycle directions.
>
> This addresses bug 199905.
> https://bugs.kde.org/show_bug.cgi?id=199905
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/apps/konsole/src/ViewManager.cpp 995529
>
> Diff: http://reviewboard.kde.org/r/1044/diff
>
>
> Testing
> -------
>
> Compiled, ran, verified behavior
>
>
> Thanks,
>
> Jacob
>
>
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic