[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Change to next tab on tab close
From:       "Robert Knight" <robertknight () gmail ! com>
Date:       2009-07-12 22:45:53
Message-ID: 20090712224553.6966.55808 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/999/#review1564
-----------------------------------------------------------

Ship it!


Needs a small comment change.  Looks good other than that.  Please commit.


trunk/KDE/kdebase/apps/konsole/src/ViewManager.cpp
<http://reviewboard.kde.org/r/999/#comment968>

    Need to update this comment to reflect the code change (s/previous view/next view)


- Robert


On 2009-07-12 17:24:44, Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/999/
> -----------------------------------------------------------
> 
> (Updated 2009-07-12 17:24:44)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Change to the next tab on tab close like all KDE programs do instead of to the previous one
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konsole/src/ViewManager.cpp 995215 
> 
> Diff: http://reviewboard.kde.org/r/999/diff
> 
> 
> Testing
> -------
> 
> Played with it, the behaviour is consistent with all the rest of KDE and with konsole of kde 3 too
> 
> 
> Thanks,
> 
> Albert
> 
>

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]