[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Small speedup in Konsole's
From:       "Robert Knight" <robertknight () gmail ! com>
Date:       2009-07-10 9:09:05
Message-ID: 20090710090905.8166.38784 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/978/#review1519
-----------------------------------------------------------

Ship it!


Looks good to me.  Please commit.

- Robert


On 2009-07-09 14:07:34, Harald Fernengel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/978/
> -----------------------------------------------------------
> 
> (Updated 2009-07-09 14:07:34)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Use only one string when painting, thus reducing one malloc+memcopy per line. \
> QString::reserve should set the initial size once, if we need to shrink the buffer \
> later, it won't realloc. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp 993475 
> 
> Diff: http://reviewboard.kde.org/r/978/diff
> 
> 
> Testing
> -------
> 
> Works like a charm on my Linux box :)
> 
> 
> Thanks,
> 
> Harald
> 
> 

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel


[prev in list] [next in list] [prev in thread] [next in thread]