[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Allow %u (user) in tab name
From:       "Kurt Hindenburg" <kurt.hindenburg () gmail ! com>
Date:       2009-04-12 0:51:39
Message-ID: 20090412005139.13284.61061 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/278/#review901
-----------------------------------------------------------

Ship it!


The previous comments were only about variable/function names so I assume it is good \
to apply.

- Kurt


On 2009-04-10 20:09:58, Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/278/
> -----------------------------------------------------------
> 
> (Updated 2009-04-10 20:09:58)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Allow %u (user) in tab name.  It reads /proc/'pid'/status for UID and then calls \
> getpwuid for user name. 
> 
> This addresses bug 154295.
> https://bugs.kde.org/show_bug.cgi?id=154295
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.h 950710 
> trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp 950710 
> 
> Diff: http://reviewboard.kde.org/r/278/diff
> 
> 
> Testing
> -------
> 
> Patch works for 4.2 branch and trunk.  Works fine on Linux (ubuntu).  Works for 'su \
> - user' and 'sudo command' 
> 
> Thanks,
> 
> Kurt
> 
> 

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel


[prev in list] [next in list] [prev in thread] [next in thread]