[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Allow %u (user) in tab name
From:       "Robert Knight" <robertknight () gmail ! com>
Date:       2009-04-07 21:49:58
Message-ID: 20090407214958.20773.18941 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/278/#review864
-----------------------------------------------------------



/branches/KDE/4.2/kdebase/apps/konsole/src/ProcessInfo.h
<http://reviewboard.kde.org/r/278/#comment539>

    Should be renamed to userId().  I know that we use pid() for the process id but \
that is incorrect really and we should stick to Qt-ish naming conventions where it \
makes sense.



/branches/KDE/4.2/kdebase/apps/konsole/src/ProcessInfo.h
<http://reviewboard.kde.org/r/278/#comment540>

    Presumably the comment means to say 'the name of the user which started the \
process'.  Replace 'current process' with 'process' since 'current' doesn't mean \
anything - a ProcessInfo instance only ever refers to one process throughout its \
lifetime.



/branches/KDE/4.2/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/278/#comment538>

    ProcessInfo is meant as a non-platform specific base class.  setUserName() should \
take a string argument and the implementation should be moved to UnixProcessInfo() 



/branches/KDE/4.2/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/278/#comment537>

    This could fail if uid_line is empty, which could happen if /proc/pid/status does \
not have the expected format


- Robert


On 2009-03-14 09:14:37, Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/278/
> -----------------------------------------------------------
> 
> (Updated 2009-03-14 09:14:37)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Allow %u (user) in tab name.  It reads /proc/'pid'/status for UID and then calls \
> getpwuid for user name. 
> 
> This addresses bug 154295.
> https://bugs.kde.org/show_bug.cgi?id=154295
> 
> 
> Diffs
> -----
> 
> /branches/KDE/4.2/kdebase/apps/konsole/src/ProcessInfo.h 938530 
> /branches/KDE/4.2/kdebase/apps/konsole/src/ProcessInfo.cpp 938530 
> 
> Diff: http://reviewboard.kde.org/r/278/diff
> 
> 
> Testing
> -------
> 
> Patch works for 4.2 branch and trunk.  Works fine on Linux (ubuntu).  Works for 'su \
> - user' and 'sudo command' 
> 
> Thanks,
> 
> Kurt
> 
> 

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel


[prev in list] [next in list] [prev in thread] [next in thread]