[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Use QToolButton for Konsole
From:       "Robert Knight" <robertknight () gmail ! com>
Date:       2009-04-07 21:32:07
Message-ID: 20090407213207.20440.60819 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/509/#review863
-----------------------------------------------------------

Ship it!


I chose push buttons originally because I thought it made sense to have a \
larger target area to click on to create new tabs if the buttons were \
enabled but I think it does look better with tool buttons.  Code looks \
good, please commit.

- Robert


On 2009-04-05 08:21:05, Sascha Peilicke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/509/
> -----------------------------------------------------------
> 
> (Updated 2009-04-05 08:21:05)
> 
> 
> Review request for Konsole and Robert Knight.
> 
> 
> Summary
> -------
> 
> here's a little patch that changes the two corner-widget buttons for \
> new/close  tab functionality to use QToolButton instead of KPushButton. \
> This way they use  less space and are more visually pleasant (see \
> screenshots). A result of this  change is the immediate visibility of the \
> new-tab button's menu. IMHO the  delayed menu of KPushButton is not \
> really intuitive or even noticeable (to be  honest, I found that feature \
> only in the code), now it's clear that the new- button has some extra \
> functionality if click-pressed. Last but not least  Konsole's tab-bar \
> does now look the same as Konqueror's. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/apps/konsole/src/ViewContainer.h 941727 
> trunk/KDE/kdebase/apps/konsole/src/ViewContainer.cpp 941727 
> 
> Diff: http://reviewboard.kde.org/r/509/diff
> 
> 
> Testing
> -------
> 
> tested with Konsole trunk
> 
> 
> Screenshots
> -----------
> 
> Visual diff
> http://reviewboard.kde.org/r/509/s/96/
> 
> 
> Thanks,
> 
> Sascha
> 
> 

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel


[prev in list] [next in list] [prev in thread] [next in thread]